All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Schirmer <jolt@tuxbox.org>
To: "Harald Küthe" <Harald.Kuethe@controlware.de>
Cc: linuxppc-embedded@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][PPC32] 2.4.27: fixes for 8xx fec.c
Date: Tue, 10 Aug 2004 10:42:12 +0200	[thread overview]
Message-ID: <41188A64.3090204@tuxbox.org> (raw)
In-Reply-To: <s1189c52.091@post2.controlware.de>

Hi,

>+
>+#ifndef	CONFIG_USE_MDIO
>+	fec_restart (dev, 0);
>+#endif
>+
> 	netif_start_queue(dev);
> 	return 0;	/* Success */
> #endif	/* CONFIG_USE_MDIO */
>  
>

Just a minor hint: you don't need the #ifndef CONFIG_USE_MDIO guard 
since you're already in the non MDIO branch (see #endif comment).

Greetings,
  Florian

  reply	other threads:[~2004-08-10  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-10  7:58 [PATCH][PPC32] 2.4.27: fixes for 8xx fec.c Harald Küthe
2004-08-10  8:42 ` Florian Schirmer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-06  6:26 Harald Küthe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41188A64.3090204@tuxbox.org \
    --to=jolt@tuxbox.org \
    --cc=Harald.Kuethe@controlware.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.