From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Wenjie Qi <qwjhust@gmail.com>, jaegeuk@kernel.org
Cc: daehojeong@google.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, qiwenjie@xiaomi.com,
sunqiuyang@huawei.com
Subject: Re: [f2fs-dev] [PATCH v4 1/2] f2fs: flush SIT journal during filesystem resize
Date: Mon, 19 Oct 2026 17:57:18 +0800 [thread overview]
Message-ID: <4118fc18-b95e-4acc-bf0d-f808ba4f4d37@kernel.org> (raw)
In-Reply-To: <7884c62cae6e4b1ad516a9ac351c2604e57d5cc5.1792116883.git.qiwenjie@xiaomi.com>
On 10/16/26 13:44, Wenjie Qi wrote:
> During a filesystem resize, SBI_IS_RESIZEFS prevents new SIT entries
> from being added to the journal and forces existing entries to the SIT
> area. However, f2fs_flush_sit_entries() returns early when there are no
> new dirty sentries, leaving existing journal entries behind.
>
> After the main area shrinks, a later checkpoint can access a journal
> entry whose segment number is outside the new geometry and trigger
> f2fs_bug_on().
>
> Only take the zero-dirty fast path when entries may be written back to
> the journal. This lets resize drain existing entries through
> remove_sits_in_journal() even when there are no new dirty sentries.
>
Cc: stable@kernel.org
> Fixes: 04f0b2eaa3b3 ("f2fs: ioctl for removing a range from F2FS")
> Reviewed-by: Daeho Jeong <daehojeong@google.com>
> Signed-off-by: Wenjie Qi <qiwenjie@xiaomi.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-10-19 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 5:44 [f2fs-dev] [PATCH v4 0/2] f2fs: fix online resize state Wenjie Qi
2026-10-16 5:44 ` [f2fs-dev] [PATCH v4 1/2] f2fs: flush SIT journal during filesystem resize Wenjie Qi
2026-10-19 9:57 ` Chao Yu via Linux-f2fs-devel [this message]
2026-10-16 5:44 ` [f2fs-dev] [PATCH v4 2/2] f2fs: refresh pinned allocation boundary after resize Wenjie Qi
2026-10-16 13:50 ` Daeho Jeong
2026-10-19 11:05 ` Chao Yu via Linux-f2fs-devel
2026-10-19 15:40 ` [f2fs-dev] [PATCH v4 0/2] f2fs: fix online resize state patchwork-bot+f2fs--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4118fc18-b95e-4acc-bf0d-f808ba4f4d37@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
--cc=sunqiuyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.