Re: Minor modification of function dcc_parse in ip_conntrack_irc.c

[Patrick McHardy <kaber@trash.net>]

Nix N. Nix wrote:

>Hi!
>
>The dcc_parse function in ip_conntrack_irc.c has a shortcoming:
>
>\1DCC <command> <param> <ip> <port> [<size>]\1\n
>
>...is the format of a DCC command (where <size> is optional).
>
>dcc_parse is responsible for finding the ip and port in this string.  It
>gets the string starting at <param>.  Unfortunately, so far, dcc_parse
>assumed that <param> does not contain any spaces.  Thus, the module
>failed to track connections implied by a string of the form
>
>\1DCC SEND "The Big Movie.avi" 10289477 1011 37546262\1\n
>
>I have remedied this problem by having it check whether there's a double
>quote and, if so, loop on to the corresponding closing double quote
>before resuming normal processing:
>  
>
How do filenames which contain a quotation mark look ? I assume the 
quotation
marks is escaped ? We should also handle this case.

Regards
Patrick