From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Andrew Morton <akpm@osdl.org>, Pasi Sjoholm <ptsjohol@cc.jyu.fi>,
Hector Martin <hector@marcansoft.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery
Date: Wed, 11 Aug 2004 18:56:46 -0400 [thread overview]
Message-ID: <411AA42E.50804@pobox.com> (raw)
In-Reply-To: <20040811223243.GA8584@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Jeff Garzik <jgarzik@pobox.com> :
> [...]
>
>>You _want_ to update those registers on every packet. Otherwise the
>>crappy 8139 chip breaks.
>
>
> The affected users noticed a clear difference when the update was in
> the no-packet branch instead of the packet processing loop. Btw the
> excerpt of the documentation outlined by Hirofumi san suggests that
> this update makes sense.
>
> Any objection/suggestion regarding a patch which would allow the update
> in both branches ?
Both branches is fine.
You'll quickly hit the RX-error-requiring-reset condition if you don't
update on each packet, though.
Jeff
next prev parent reply other threads:[~2004-08-11 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 21:43 [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery Francois Romieu
2004-08-05 21:45 ` [PATCH 2.6.8-rc3-mm1 2/2] 8139too: be sure to progress durin rtl8139_rx() Francois Romieu
2004-08-11 19:17 ` [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery Jeff Garzik
2004-08-11 22:32 ` Francois Romieu
2004-08-11 22:56 ` Jeff Garzik [this message]
2004-08-12 20:28 ` Francois Romieu
2004-08-14 18:58 ` Pasi Sjoholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411AA42E.50804@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=hector@marcansoft.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=netdev@oss.sgi.com \
--cc=ptsjohol@cc.jyu.fi \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.