From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S267771AbUHMXte@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S267771AbUHMXte (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 13 Aug 2004 19:49:34 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267772AbUHMXtc
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 13 Aug 2004 19:49:32 -0400
Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:45540 "EHLO
	www.linux.org.uk") by vger.kernel.org with ESMTP id S267771AbUHMXta
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Aug 2004 19:49:30 -0400
Message-ID: <411D536A.7050206@pobox.com>
Date: Fri, 13 Aug 2004 19:48:58 -0400
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Pete Zaitcev <zaitcev@redhat.com>
CC: Alan Cox <alan@lxorguk.ukuu.org.uk>, Neil Horman <nhorman@redhat.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       mike_phillips@urscorp.com
Subject: Re: [Patch} to fix oops in olympic token ring driver on media disconnect
References: <411D126B.6090303@redhat.com>	<1092434830.25002.25.camel@localhost.localdomain> <20040813163527.17aec0b5@lembas.zaitcev.lan>
In-Reply-To: <20040813163527.17aec0b5@lembas.zaitcev.lan>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Pete Zaitcev wrote:
> On Fri, 13 Aug 2004 23:07:16 +0100
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> 
> 
>>On Gwe, 2004-08-13 at 20:11, Neil Horman wrote:
>>
>>>the olympic_close routine was waiting on.  This patch cleans that up.
>>>
>>>Tested by me, on 2.4 and 2.6 with good, working results, and no more oopses.
>>
>>Should it not be blocking the IRQs on the chip as well ?
> 
> 
> I assumed that old olympic_close() did, but perhaps it didn't after all.
> There is nothing like the following in it:
> 
> +#define DISABLE_IRQS(base_addr) do { \
> +   writel(LISR_LIE,(base_addr)+LISR_RWM);\
> +   writel(SISR_MI,(base_addr)+SISR_RWM);\
> +} while(0)
> 
> This is curious. If something was never used, how do we know if it works?
> Maybe it's safer just to leave things as Neil did.


Well, regardless, Neil's patch is IMO a good first step.

There is plenty of work in olympic for any motivated person :)

	Jeff