From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267754AbUHPPYd (ORCPT ); Mon, 16 Aug 2004 11:24:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267697AbUHPPUL (ORCPT ); Mon, 16 Aug 2004 11:20:11 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:27360 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S267702AbUHPPTK (ORCPT ); Mon, 16 Aug 2004 11:19:10 -0400 Message-ID: <4120D05D.3020602@pobox.com> Date: Mon, 16 Aug 2004 11:18:53 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mike_Phillips@URSCorp.com CC: Alan Cox , Linux Kernel Mailing List , Neil Horman , Pete Zaitcev Subject: Re: [Patch} to fix oops in olympic token ring driver on media disconnect References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Mike_Phillips@URSCorp.com wrote: >>Well, regardless, Neil's patch is IMO a good first step. > > > Neil's patch is to make the annoying regression test failure go away. To > be honest I have had *one* user email me that this is a problem and once I > gave them the "don't remove the cable on token ring, its not ethernet" > talk, they were fine. Well I * disagree the kernel should oops, * I disagree that olympic should call free_irq in the interrupt handler, and * I disagree that olympic should do 'dev->stop = NULL' at all, much less in the interrupt handler sorry, Jeff