Re: libipq, kernel panics/oopses, and other undesirable traits

[Patrick McHardy <kaber@trash.net>]

Matt Walters wrote:

>On Mon, 2004-08-16 at 15:38, Patrick McHardy wrote:
>  
>
>>skb_tailroom should return 0 in this case and the skb should be linearized
>>by skb_copy_expand already. The check isn't triggered because this line is
>>wrong:
>>
>>diff = v->data_len - e->skb->len
>>
>>skb->len is the total length, including fragments. If we want to copy to it,
>>we either need to linearize it or look at skb_headlen(skb). It's complicated
>>getting everything right, I need to think about it some more.
>>    
>>
>
>	Yeah, and for some twisted reason I was figuring on skb_copy_bits to do
>that (since it *does* unwind fragment lists, etc).  My apologies for the
>waste of bandwidth.
>  
>
No problem, your testing provided valuable information about the cause 
of the
problem.

Regards
Patrick