From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal: fix bug in x86 cmpset
Date: Thu, 29 Sep 2016 18:34:58 +0200 [thread overview]
Message-ID: <4122748.D2hJ4kS1ho@xps13> (raw)
In-Reply-To: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
2016-09-30 02:54, Nikhil Rao:
> The original code used movl instead of xchgl, this caused
> rte_atomic64_cmpset to use ebx as the lower dword of the source
> to cmpxchg8b instead of the lower dword of function argument "src".
Could you please start the explanation with a statement of
what is wrong from an user point of view?
It could help to understand how severe it is.
next prev parent reply other threads:[~2016-09-29 16:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 21:24 [PATCH] eal: fix bug in x86 cmpset Nikhil Rao
2016-09-29 13:05 ` Christian Ehrhardt
2016-09-29 13:16 ` Rao, Nikhil
2016-09-29 14:21 ` Thomas Monjalon
2016-09-29 16:34 ` Thomas Monjalon [this message]
2016-11-06 21:09 ` Thomas Monjalon
2017-02-09 16:53 ` Thomas Monjalon
2017-02-10 10:39 ` Hunt, David
2017-02-10 10:53 ` Thomas Monjalon
2017-02-10 11:56 ` Hunt, David
2017-02-10 16:46 ` Stephen Hemminger
2017-03-09 15:39 ` Thomas Monjalon
2017-09-04 13:02 ` Bruce Richardson
2017-09-04 13:06 ` Bruce Richardson
2017-10-26 22:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4122748.D2hJ4kS1ho@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.