All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH 1/2] debugfs: add small file operations for most files
Date: Tue, 26 Nov 2024 15:22:15 +0100	[thread overview]
Message-ID: <41242bd65b27736f6dc0115d2ad2422d5b157d23.camel@sipsolutions.net> (raw)
In-Reply-To: <CAMuHMdXbCaMBwjrb+ZJj+MMQvOm8Y=xKfaxVhYVb79WyO4Z-4Q@mail.gmail.com>

On Tue, 2024-11-26 at 15:16 +0100, Geert Uytterhoeven wrote:
> 
> Assuming non-wireless drivers can be converted, too?  As none of the
> classical m68k machines support wireless, so far nothing is gained...

Oh, most debugfs files can be converted, since most don't do anything
beyond simple_open/read/write/seek and those are covered.

> > Unfortunately this requires another set of full file ops,
> > increasing the size by 536 bytes (x86-64), but that's still
> 
> 226 on m68k.

Not that bad, I guess. So if that's 226 bytes and before you had 447
we'd probably only need to convert 4 instances to have a net win :)

> Thanks, that fixed the issue!
> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>

Great, thanks for testing!

I'll do some more testing of my own and then figure out how to get it
into the tree. Greg, any thoughts on that?

johannes

      reply	other threads:[~2024-11-26 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 13:18 [PATCH 1/2] debugfs: add small file operations for most files Johannes Berg
2024-10-22 13:18 ` [PATCH 2/2] wifi: mac80211: convert debugfs files to short fops Johannes Berg
2024-10-22 13:55 ` [PATCH 1/2] debugfs: add small file operations for most files Greg Kroah-Hartman
2024-10-22 14:02   ` Johannes Berg
2024-11-25 12:37 ` Geert Uytterhoeven
2024-11-26  8:38   ` Geert Uytterhoeven
2024-11-26  9:37     ` Johannes Berg
2024-11-26 14:16       ` Geert Uytterhoeven
2024-11-26 14:22         ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41242bd65b27736f6dc0115d2ad2422d5b157d23.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.