From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Bryant Subject: Re: [PATCH][RFC] fix ACPI IRQ routing after S3 suspend Date: Fri, 20 Aug 2004 16:42:03 -0400 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <4126621B.3090701@optonline.net> References: <88056F38E9E48644A0F562A38C64FB6002A934AC@scsmsx403.amr.corp.intel.com> <41265443.9050800@optonline.net> <200408202201.54083.stefandoesinger@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <200408202201.54083.stefandoesinger-RbZlAiThDcE@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: stefandoesinger-RbZlAiThDcE@public.gmane.org Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Pallipadi, Venkatesh" , "Brown, Len" , Linux Kernel list , "Li, Shaohua" List-Id: linux-acpi@vger.kernel.org Stefan D=F6singer wrote: >If I re-programm the IRQ to something else than IRQ10, the device do= esn't=20 >resume too. So it's not only a problem of IRQ 11. > =20 > Seems like an anything-at-all-other-than-IRQ-10 problem. If the curre= nt=20 thinking is right, your BIOS is assigning IRQ10 during boot, so movin= g=20 it anywhere else is what causes problems. But the current thinking doesn't quite seem right, because it seeems= =20 like we're seeing these problems after the irqrouter is resumed. Can = you=20 verify that with the attached patch? The patch should give us enough= =20 information as long as you've got the proper kernel loglevel set. Now, I wonder if the only reason it works when you set IRQ 10 is that= =20 some other driver is unconditionally claiming the interrupt... Nathan >The ipw2100 driver calls pci_disable_device in it's suspend handler.= But I=20 >think the ipw2100 maintainers need help with suspend/resume because = James=20 >Ketrenos can't test it on his own system. > =20 > pci_disable_device() only turns off bus-mastering, it doesn't unmap t= he=20 I/O or disable the slot. Maybe we also need to set power state D3 and= do=20 a device-specific disable-interrupts, but I think D0 gets restored fo= r=20 us pretty early during resume anyway... Anyway, something doesn't quite add up... Nathan ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268737AbUHTUtG (ORCPT ); Fri, 20 Aug 2004 16:49:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268764AbUHTUpr (ORCPT ); Fri, 20 Aug 2004 16:45:47 -0400 Received: from mta9.srv.hcvlny.cv.net ([167.206.5.42]:31410 "EHLO mta9.srv.hcvlny.cv.net") by vger.kernel.org with ESMTP id S268735AbUHTUnU (ORCPT ); Fri, 20 Aug 2004 16:43:20 -0400 Date: Fri, 20 Aug 2004 16:42:03 -0400 From: Nathan Bryant Subject: Re: [ACPI] [PATCH][RFC] fix ACPI IRQ routing after S3 suspend In-reply-to: <200408202201.54083.stefandoesinger@gmx.at> To: stefandoesinger@gmx.at Cc: acpi-devel@lists.sourceforge.net, "Pallipadi, Venkatesh" , "Brown, Len" , Linux Kernel list , "Li, Shaohua" Message-id: <4126621B.3090701@optonline.net> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 8BIT X-Accept-Language: en-us, en User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 References: <88056F38E9E48644A0F562A38C64FB6002A934AC@scsmsx403.amr.corp.intel.com> <41265443.9050800@optonline.net> <200408202201.54083.stefandoesinger@gmx.at> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Stefan Dösinger wrote: >If I re-programm the IRQ to something else than IRQ10, the device doesn't >resume too. So it's not only a problem of IRQ 11. > > Seems like an anything-at-all-other-than-IRQ-10 problem. If the current thinking is right, your BIOS is assigning IRQ10 during boot, so moving it anywhere else is what causes problems. But the current thinking doesn't quite seem right, because it seeems like we're seeing these problems after the irqrouter is resumed. Can you verify that with the attached patch? The patch should give us enough information as long as you've got the proper kernel loglevel set. Now, I wonder if the only reason it works when you set IRQ 10 is that some other driver is unconditionally claiming the interrupt... Nathan >The ipw2100 driver calls pci_disable_device in it's suspend handler. But I >think the ipw2100 maintainers need help with suspend/resume because James >Ketrenos can't test it on his own system. > > pci_disable_device() only turns off bus-mastering, it doesn't unmap the I/O or disable the slot. Maybe we also need to set power state D3 and do a device-specific disable-interrupts, but I think D0 gets restored for us pretty early during resume anyway... Anyway, something doesn't quite add up... Nathan