From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755265AbbJUP5e (ORCPT ); Wed, 21 Oct 2015 11:57:34 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:50751 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbbJUP5c (ORCPT ); Wed, 21 Oct 2015 11:57:32 -0400 From: Arnd Bergmann To: David Miller Cc: linux@roeck-us.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] net: hisilicon: Never build on SPARC Date: Wed, 21 Oct 2015 17:57:24 +0200 Message-ID: <4129407.LpDXnpSZOL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151021.083311.2193871332944250588.davem@davemloft.net> References: <1445437773-23261-1-git-send-email-linux@roeck-us.net> <5627A792.3020201@roeck-us.net> <20151021.083311.2193871332944250588.davem@davemloft.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:6gLEFzqRoD3xsgUbHC6tK0mEcsZaangqULxS2UEYRwvFD9AqIWm K0jLpOozqGwdbTf43Swy5rWEqpna7FX9sED47xrgMHnksyYRXF7nlpOZx2vyxCFApdbIRd7 2O/6ivTDOXJ42tcHL7L+8J3xS0ga894QRosPwf1Xb3liNFNp/rd2uaDDHpQujYd41wEqfyu XMTKpTWHWK0OI/lL7HedQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MO3sRdXMEpM=:YtCX/1C6PxplERc8NcmjlC UgdJG7MxZUmU9DVw8OdElbyUC212oU+xbDHd6AOlcjDWid+LxX0PcorBXTLRIp1sA182/8qm5 lTEWKB/Zw2/3aZ5RukXmPcyunCN3j27gyY0c/+A1Oht6zM1pyj49AEAJoYIo/vsZCZnK/4XAN Y5A296HY9WSXvAi6GNjcw0XXDllRiJAcauVCiYQ7/ON1La4tr/ZJJq3U2nAkusH/oxHG/H+3u KgTSckJRGAGsANkard+svaboq9aNAHf9d+RW8t7duFYe+qdzZkp8bfZmu1s1/KrF3N6B7CDbF OZR1m9P3e3LaTxfT/NsXTXGXQWfXcLrVCG2xbdYMp6a8rA0kxArUjvyo00A77wyMpV+/MAUsR cXQRdAnUgGZ2JjUsoQIM2wp156sDVfWrc7h1JkfVmbNH8VduKfhGj1k5bpoCmT/xD1VqZlm+f d2R45cgFHQd7BdarUU7HXI6LK26EwZaEFklpZPGxW8+2Q2T09LRWHNj6+Yfhkqozy8pyWDY28 FNXO2bdcSPUgG95f1sT9al5T/EYHndVcOt+/xIggBnkLkYIPh+ohI8mzPDWfieXj7s107E/5x Bfge8C30V/fDMq3cbKwZWQBt4Q1I4Ozr6OBPJrzEROt03M9/A2B6DHnn4T1VQzpqV52Nen017 A4nWUrC52vxmS7M27AvmafVsBi6hK7dm6XewV79ZNmIO3Sy4hgcYxh8tHx9DZ8R7ELQl5zf7k EzISKCCdezUN2PAG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 21 October 2015 08:33:11 David Miller wrote: > From: Guenter Roeck > Date: Wed, 21 Oct 2015 07:56:18 -0700 > > >> @@ -57,6 +57,11 @@ extern int of_dma_get_range(struct device_node *np, > >> u64 *dma_addr, > >> u64 *paddr, u64 *size); > >> extern bool of_dma_is_coherent(struct device_node *np); > >> #else /* CONFIG_OF_ADDRESS */ > >> +static inline u64 of_translate_address(struct device_node *np, const > >> __be32 *addr) > >> +{ > >> + return 0; > > > > Maybe return OF_BAD_ADDR ? > > The thing to really do on sparc, is just return the address raw untranslated > because that just works. > We still need to check #address-cells, right? Something like this? static inline u64 of_translate_address(struct device_node *np, const __be32 *addr) { #if defined(CONFIG_SPARC) || defined(CONFIG_M68K) int pna = of_n_addr_cells(np); u64 ret = be32_to_cpu(addr[pna - 1]); if (pna > 1) ret += (u64)be32_to_cpu(addr[pna - 2]) << 32; return ret; #else return OF_BAD_ADDR; #endif } Arnd