From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@lists.netfilter.org, kadlec@blackhole.kfki.hu
Subject: Re: [PATCH] ipt_dstlimit spinlock fixup
Date: Mon, 23 Aug 2004 22:49:22 +0200 [thread overview]
Message-ID: <412A5852.4050104@trash.net> (raw)
In-Reply-To: <20040823201231.GA2046@linuxace.com>
Phil Oester wrote:
>On Mon, Aug 23, 2004 at 08:47:06PM +0200, Patrick McHardy wrote:
>
>
>>Phil Oester wrote:
>>
>>
>>
>>>Since ipt_dstlimit makes use of MUST_BE_LOCKED macro, compiling
>>>without CONFIG_NETFILTER_DEBUG causes errors. Fix below.
>>>
>>>
>>>
>>Jozsefs conntrack_locking patch has the same problem, I wonder if we
>>should introduce a spinlock_debug_t (if that is not taken yet) or
>>better yet, kill lockhelp.h.
>>
>>
>
>Or option 3: remove the MUST_BE_LOCKED users in both files. lockhelp
>does seem to be, er, helpful in some cases.
>
>
With the conntrack patches we need to remove it from ip_conntrack_core.c
and ip_nat_core.c, after that there really would be no readon for keeping
it at all. There isn't any readon even today, spinlock.h already offers
the same features.
Regards
Patrick
>Phil
>
>
>
prev parent reply other threads:[~2004-08-23 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-22 15:33 [PATCH] ipt_dstlimit spinlock fixup Phil Oester
2004-08-23 18:47 ` Patrick McHardy
2004-08-23 20:12 ` Phil Oester
2004-08-23 20:49 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412A5852.4050104@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.