From: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
lhms <lhms-devel@lists.sourceforge.net>,
William Lee Irwin III <wli@holomorphy.com>,
Hirokazu Takahashi <taka@valinux.co.jp>,
ncunningham@linuxmail.org
Subject: Re: [Lhms-devel] Re: [RFC/PATCH] free_area[] bitmap elimination[1/3]
Date: Wed, 25 Aug 2004 09:24:06 +0900 [thread overview]
Message-ID: <412BDC26.8020007@jp.fujitsu.com> (raw)
In-Reply-To: <1093392120.4030.119.camel@nighthawk>
Dave Hansen wrote:
>>But "size" is a variable which is used in memmap_init_zone(size, start_pfn, zone)
>>and I think it is better not to change a name of an inherited variable from a caller.
>>(I say size is inherited from memmap_init_zone() in its meaning.)
>
>
> Don't use existing bad code as an example :) I don't see any good
> reason that you can't change it. Nobody complains when making variable
> names *more* descriptive.
>
Hmm, I'll consider more descriptive name and what kind of code is easier to read .
--Kame
--
--the clue is these footmarks leading to the door.--
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-08-25 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-24 12:28 [RFC/PATCH] free_area[] bitmap elimination[1/3] Hiroyuki KAMEZAWA
[not found] ` <1093366752.1009.44.camel@nighthawk>
[not found] ` <412BD597.1050001@jp.fujitsu.com>
[not found] ` <1093392120.4030.119.camel@nighthawk>
2004-08-25 0:24 ` Hiroyuki KAMEZAWA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412BDC26.8020007@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=haveblue@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
--cc=ncunningham@linuxmail.org \
--cc=taka@valinux.co.jp \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.