From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Courtier-Dutton Subject: Re: [PATCH] Change alsamixer to show different views. Playback controls, or Capture controls. Date: Fri, 27 Aug 2004 22:16:11 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: <412FA49B.3020806@superbug.demon.co.uk> References: <412F2E4E.4080300@superbug.demon.co.uk> <412F6481.7030300@superbug.demon.co.uk> <412F709D.10903@superbug.demon.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070106070606090602040301" Return-path: Received: from anchor-post-31.mail.demon.net (anchor-post-31.mail.demon.net [194.217.242.89]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id 43EF1210 for ; Fri, 27 Aug 2004 23:16:12 +0200 (MEST) In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org This is a multi-part message in MIME format. --------------070106070606090602040301 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Takashi Iwai wrote: > At Fri, 27 Aug 2004 18:34:21 +0100, > James Courtier-Dutton wrote: > >>Takashi Iwai wrote: >> >>>>I have a question. The "Mic Boost" seems to think it is a "Playback" >>>>control. What would be the best way to getting that to be a "Capture" >>>>control. Would simply editing it in ac97_codec.c be enough? >>> >>> >>>Hmm, when you change the control name itself, it breaks slightly >>>compatibility with older version. >> >>What does the name have to be compatible with? >>I.e. What program might break if we change this in ac97_codec.c ? > > > Dunno. But, at least, when you run "alsactl restore", the status > won't be restored. > > > Takashi > > Thats true, but from a purely conceptual point of view, I think the Mic Boost should be associated with Capture and not associated with Playback. I attach a patch to do just that. James --------------070106070606090602040301 Content-Type: text/plain; name="mic-boost.diff.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mic-boost.diff.txt" Index: alsa-driver/alsa-kernel/pci/ac97/ac97_codec.c =================================================================== RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_codec.c,v retrieving revision 1.144 diff -u -r1.144 ac97_codec.c --- alsa-driver/alsa-kernel/pci/ac97/ac97_codec.c 11 Aug 2004 18:51:58 -0000 1.144 +++ alsa-driver/alsa-kernel/pci/ac97/ac97_codec.c 27 Aug 2004 21:10:44 -0000 @@ -687,7 +687,7 @@ static const snd_kcontrol_new_t snd_ac97_controls_mic[3] = { AC97_SINGLE("Mic Playback Switch", AC97_MIC, 15, 1, 1), AC97_SINGLE("Mic Playback Volume", AC97_MIC, 0, 15, 1), -AC97_SINGLE("Mic Boost (+20dB)", AC97_MIC, 6, 1, 0) +AC97_SINGLE("Mic Boost (+20dB) Capture Switch", AC97_MIC, 6, 1, 0) }; static const snd_kcontrol_new_t snd_ac97_control_capture_src = { --------------070106070606090602040301-- ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click