From: Brian Gerst <bgerst@quark.didntduck.org>
To: Andrew Morton <akpm@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix hardcoded value in vsyscall.lds
Date: Sat, 28 Aug 2004 12:01:56 -0400 [thread overview]
Message-ID: <4130AC74.8010600@quark.didntduck.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
The last attempt to clean this up still left a hardcoded constant (the
offset from __FIXADDR_TOP). This patch moves VSYSCALL_BASE to
asm-offsets.c.
--
Brian Gerst
[-- Attachment #2: vsyscall-fixmap --]
[-- Type: text/plain, Size: 955 bytes --]
diff -urN linux-2.6.9-rc1-bk/arch/i386/kernel/asm-offsets.c linux/arch/i386/kernel/asm-offsets.c
--- linux-2.6.9-rc1-bk/arch/i386/kernel/asm-offsets.c 2004-06-23 18:06:12.000000000 -0400
+++ linux/arch/i386/kernel/asm-offsets.c 2004-08-27 10:55:04.384806536 -0400
@@ -62,4 +62,5 @@
sizeof(struct tss_struct));
DEFINE(PAGE_SIZE_asm, PAGE_SIZE);
+ DEFINE(VSYSCALL_BASE, __fix_to_virt(FIX_VSYSCALL));
}
diff -urN linux-2.6.9-rc1-bk/arch/i386/kernel/vsyscall.lds.S linux/arch/i386/kernel/vsyscall.lds.S
--- linux-2.6.9-rc1-bk/arch/i386/kernel/vsyscall.lds.S 2004-08-26 17:17:35.000000000 -0400
+++ linux/arch/i386/kernel/vsyscall.lds.S 2004-08-27 10:54:41.293818300 -0400
@@ -3,9 +3,7 @@
* object prelinked to its virtual address, and with only one read-only
* segment (that fits in one page). This script controls its layout.
*/
-#include <asm/fixmap.h>
-
-VSYSCALL_BASE = __FIXADDR_TOP - 0x1000;
+#include <asm/asm_offsets.h>
SECTIONS
{
reply other threads:[~2004-08-28 16:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4130AC74.8010600@quark.didntduck.org \
--to=bgerst@quark.didntduck.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.