From: "Brüns, Stefan" <Stefan.Bruens@rwth-aachen.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] efi_loader: fix bug in efi_get_memory_map
Date: Thu, 27 Jul 2017 14:44:17 +0000 [thread overview]
Message-ID: <4132452.iGmGEkvGJM@sbruens-linux> (raw)
In-Reply-To: <CAF6AEGt74a82daUQkRSav9p_7VRXYC6sxAs_SzunmS5itot1Vg@mail.gmail.com>
On Mittwoch, 26. Juli 2017 22:25:29 CEST Rob Clark wrote:
> On Wed, Jul 26, 2017 at 4:10 PM, Alexander Graf <agraf@suse.de> wrote:
> > On 26.07.17 20:34, Rob Clark wrote:
> >> When booting shim -> fallback -> shim -> grub -> linux the memory map is
> >> a bit larger than the size linux passes in on the first call. But in
> >> the EFI_BUFFER_TOO_SMALL case we were not passing back the updated size
> >> to linux so it would loop forever.
> >>
> >> Signed-off-by: Rob Clark <robdclark@gmail.com>
> >
> > The spec is actually very explicit about this case. It says in the
> > EFI_BUFFER_TOO_SMALL case, we *have* to return the map size.
>
> yes, that is what I fixed. We *weren't* returning the required buffer
> size before :-)
Sigh, yes, this was correct in the first 3 versions of the patch series, but
unfortunately broken in v4 which was actually committed ...
See: https://lists.denx.de/pipermail/u-boot/2016-October/268766.html
Actually, the map_size variable is no longer needed, if you assign to
*memory_map_size directly.
Anyway, this patch is:
Reviewed-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Kind regards,
Stefan
next prev parent reply other threads:[~2017-07-27 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 18:34 [U-Boot] [PATCH] efi_loader: fix bug in efi_get_memory_map Rob Clark
2017-07-26 20:10 ` Alexander Graf
2017-07-26 20:25 ` Rob Clark
2017-07-27 14:44 ` Brüns, Stefan [this message]
2017-07-28 22:27 ` [U-Boot] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4132452.iGmGEkvGJM@sbruens-linux \
--to=stefan.bruens@rwth-aachen.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.