Jeff Garzik wrote:
> Jeff Garzik wrote:
> 
>> me either, unless I can figure out a way to detect that a disk is PATA 
>> not SATA.  Nothing is obvious from the specs on www.t13.org, but who 
>> knows.
> 
> 
> According to the Serial ATA docs, IDENTIFY DEVICE word 93 will be zero 
> if it's Serial ATA.  Who knows if that's true, given the wierd wild 
> world of ATA devices.
> 

I'm assuming here that if the driver uses sata_phy_reset in libata-core then it's actually a SATA 
controller.

Patch attached, tested and verified.
SATA drives (of which I only have one brand) report IDENTIFY DEVICE word 93 as zero, ATA devices 
behind the bridge (Of which I only have one brand) report at a minimum bit 13 to report an 80 
conductor cable.

Like I said before, my assumptions are

A) IDENTIFY DEVICE and the associated Word 93 register have been *Mandatory* at least since ATA-5

B) ATA-5 maxed out at < udma/100 and did not contain lba48

C) The SATA->PATA bridge looks like an 80 conductor cable and thus on any drive that supports lba48 
will always present a non-zero value in IDENTIFY DEVICE Word 93.

It works here anyway.
Patch against vanilla 2.6.9-rc1 attached (including your ata.h patch)

Thanks again for all the help. I'll see if I can get some other older ATA drives to test with (I 
might have to gut all the machines in the office for the weekend)

Regards,
Brad