From: Jeff Garzik <jgarzik@pobox.com>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: Peter Holik <peter@holik.at>,
linux-kernel@vger.kernel.org,
Francois Romieu <romieu@fr.zoreil.com>,
netdev@oss.sgi.com
Subject: Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27
Date: Mon, 30 Aug 2004 13:33:00 -0400 [thread overview]
Message-ID: <413364CC.8090901@pobox.com> (raw)
In-Reply-To: <200408301157.03334.vda@port.imtp.ilyichevsk.odessa.ua>
Denis Vlasenko wrote:
> On Monday 30 August 2004 10:28, Peter Holik wrote:
>
>>static void set_rx_mode(struct net_device *dev)
>>{
>> spinlock_t *lp = &((struct netdev_private *)dev->priv)->lock;
>> unsigned long flags;
>> spin_lock_irqsave(lp, flags);
>> __set_rx_mode(dev);
>>- spin_unlock_irqrestore(&lp, flags);
>>+ spin_unlock_irqrestore(lp, flags);
>>}
>
>
> Oh... it was my change which was buggy... Thanks for the fix!
>
> Jeff, 2.6 most probably has the same bug.
Upstream 2.6 already has the fix...
Jeff
next prev parent reply other threads:[~2004-08-30 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-30 7:28 PROBLEM: fix fealnx.c hangs on SMP, 2.4.27 Peter Holik
2004-08-30 8:57 ` Denis Vlasenko
2004-08-30 17:33 ` Jeff Garzik [this message]
2004-08-30 9:04 ` Jeff Garzik
2004-08-30 11:10 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413364CC.8090901@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=peter@holik.at \
--cc=romieu@fr.zoreil.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.