Neil Brown wrote:
> On Thursday August 26, paul.clements@steeleye.com wrote:

> I'm mostly happy with this patch.
> I'd like to ask for two changes before it gets committed.
> 
> First - update the relevant man pages to explain -H and SIGUSR1
> usage. 

OK, I've added sections to the mountd and statd man pages.

> Second, I have a pathological aversion to "system(3)" for this sort
> of task.  I start worrying about stray quotes and other magic
> characters.
> I would much prefer something like:
> 
>   sprintf(buf, "%.8x" args3)
>   switch(pid=fork()) {
> 	case 0: execl(ha_callout_prog,"callout",arg1,arg2,buf,NULL);
> 		exit(1);
> 	case -1: perror(PROGNAME ": fork"); break;
> 	default: waitpid(pid, NULL, 0);
>   }

OK, I've changed this.

> Also, I would really prefer the count was passed in decimal (%d) - it
> is more traditional.  If hex is needed, the program can convert it.
> (why it is hex in "rmtab" I really don't know)....

OK, I pass it in decimal now.

New patch attached.

--
Paul