From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 09/21] modetest: Allow specifying plane position Date: Thu, 04 Apr 2013 18:24:24 +0200 Message-ID: <41368838.J9gAzi3Fii@avalon> References: <1363704962-14077-1-git-send-email-laurent.pinchart@ideasonboard.com> <20130327155720.GE4469@intel.com> <20130327171531.GF4469@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 97498E645B for ; Thu, 4 Apr 2013 09:23:25 -0700 (PDT) In-Reply-To: <20130327171531.GF4469@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Ville, On Wednesday 27 March 2013 19:15:31 Ville Syrj=E4l=E4 wrote: > On Wed, Mar 27, 2013 at 05:57:20PM +0200, Ville Syrj=E4l=E4 wrote: > > On Tue, Mar 19, 2013 at 03:55:50PM +0100, Laurent Pinchart wrote: > > > Extend the -P option to allow specifying the plane x and y offsets. T= he > > > position is optional, if not specified the plane will be positioned at > > > the center of the screen as before. > > > = > > > Signed-off-by: Laurent Pinchart > > > --- > > > = > > > tests/modetest/modetest.c | 72 ++++++++++++++++++++++++++++++-------= --- > > > 1 file changed, 57 insertions(+), 15 deletions(-) > > > = > > > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c > > > index 7153a40..f95efe6 100644 > > > --- a/tests/modetest/modetest.c > > > +++ b/tests/modetest/modetest.c > > > @@ -645,6 +645,7 @@ struct connector_arg { > > > = > > > struct plane_arg { > > > = > > > uint32_t con_id; /* the id of connector to bind to */ > > > = > > > + uint32_t x, y; > > = > > I'd like the coordinates to allow negative values too. > = > Tested it and it actually works w/ negative values thanks to the way > strtoul() works :) The only real obstacle is the magic '-1' handling. > I guess you should just give up on magic values and add some flag to > indicate whether the user provided the coords or not. Done :-) I'll post a new version. > Also I must say that I don't like the syntax you used for specifying the > coords. '(' and ')' need to be escaped or the shell eats them. I've been > using the x11 -geometry syntax whenever I have to deal with the x/y/w/h > combination. It's a reasonably well known syntax and doesn't have these > shell issues. Maybe you could use it here as well. Given that negative coordinates in the X geometry syntax don't match we wha= t = need, should I keep the current syntax, abuse the X geometry syntax, or use = something else ? -- = Regards, Laurent Pinchart