From: Tkhai Kirill <tkhai@yandex.ru>
To: sparclinux@vger.kernel.org
Subject: [PATCH]SPARC32: Fixed unaligned memory copying in function __csum_partial_copy_sparc_generic
Date: Tue, 10 May 2011 12:31:41 +0000 [thread overview]
Message-ID: <41391305030701@web6.yandex.ru> (raw)
In-Reply-To: <1304845558.9492.14.camel@big>
Hello, Dave!
I'm sorry, there is a error in my previous letter. I added excess annul field to bge.
Final patch from me is following:
When we are in the label cc_dword_align, registers %o0 and %o1 have the same last 2 bits,
but it's not guaranteed one of they is zero. So we can get unaligned memory access
in label ccte. Example of parameters which lead to this:
%o0=0x7ff183e9, %o1=0x8e709e7d, %g1=3
With the parameters I had a memory corruption, when the additional 5 bytes were rewritten.
This patch corrects the error.
One comment to the patch. We don't care about the third bit in %o1, because cc_end_cruft
stores word or less.
Thanks. Kirill.
Signed-off-by: Tkhai Kirill <tkhai@yandex.ru>
---
--- linux-2.6.38.5/arch/sparc/lib/checksum_32.S.orig 2011-05-06 22:54:25.000000000 +0400
+++ linux-2.6.38.5/arch/sparc/lib/checksum_32.S 2011-05-08 11:43:35.000000000 +0400
@@ -289,10 +289,16 @@ cc_end_cruft:
/* Also, handle the alignment code out of band. */
cc_dword_align:
- cmp %g1, 6
- bl,a ccte
+ cmp %g1, 16
+ bge 1f
+ srl %g1, 1, %o3
+2: cmp %o3, 0
+ be,a ccte
andcc %g1, 0xf, %o3
- andcc %o0, 0x1, %g0
+ andcc %o3, %o0, %g0 ! Check %o0 only (%o1 has the same last 2 bits)
+ be,a 2b
+ srl %o3, 1, %o3
+1: andcc %o0, 0x1, %g0
bne ccslow
andcc %o0, 0x2, %g0
be 1f
next prev parent reply other threads:[~2011-05-10 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 9:05 [PATCH]SPARC32: Fixed unaligned memory copying in function kirill
2011-05-08 23:44 ` David Miller
2011-05-09 8:49 ` [PATCH]SPARC32: Fixed unaligned memory copying in function __csum_partial_copy_sparc_generic Tkhai Kirill
2011-05-09 18:33 ` [PATCH]SPARC32: Fixed unaligned memory copying in function David Miller
2011-05-09 19:55 ` [PATCH]SPARC32: Fixed unaligned memory copying in function __csum_partial_copy_sparc_generic Tkhai Kirill
2011-05-10 12:31 ` Tkhai Kirill [this message]
2011-05-10 20:28 ` [PATCH]SPARC32: Fixed unaligned memory copying in function David Miller
2011-05-10 23:21 ` [PATCH]SPARC32: Fixed unaligned memory copying in function __csum_partial_copy_sparc_generic Tkhai Kirill
2011-05-11 12:53 ` Daniel Hellstrom
2011-05-11 17:10 ` [PATCH]SPARC32: Fixed unaligned memory copying in function David Miller
2011-05-12 4:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41391305030701@web6.yandex.ru \
--to=tkhai@yandex.ru \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.