From: Thomas Monjalon <thomas@monjalon.net>
To: Dekel Peled <dekelp@mellanox.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org, dpdk-dev <dev@dpdk.org>,
Jerin Jacob <jerinjacobk@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
maxime.coquelin@redhat.com, Olivier Matz <olivier.matz@6wind.com>,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Asaf Penso <asafp@mellanox.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
Date: Thu, 06 Aug 2020 23:57:57 +0200 [thread overview]
Message-ID: <4140580.jaiIUUfkUx@thomas> (raw)
In-Reply-To: <CACZ4nhuVsAhip0VNtCFeC5NaO2_3asisQNSmnpp+NqS2NrAZ1A@mail.gmail.com>
> > >> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> > >> to include an additional value, indicating existence or absence of VLAN
> > >> headers following the current header, as proposed in RFC
> > >> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > >> Because of ABI break this change is proposed for 20.11.
> > >>
> > >> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > >> ---
> > >> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct
> > rte_flow_item_vlan``
> > >> + structs will be modified, to include an additional value, indicating
> > existence
> > >> + or absence of a VLAN header following the current header, as
> > proposed in RFC
> > >> + https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > > Specifying match patterns on none or multiple extensions
> > > is difficult to manage with rte_flow.
> > > It seems this approach of adding explicit fields in the items
> > > can work well.
> > >
> > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > Similar to IPv6, it looks required to add extra information to ETH (and may
> > be VLAN) item, but I'm not sure that proposed solution is 100% OK.
> > Anyway, the scope of the deprecation notice is ongoing changes, so:
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied
next prev parent reply other threads:[~2020-08-06 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 16:01 [dpdk-dev] [PATCH] doc: announce change in ETH item struct Dekel Peled
2020-08-05 3:39 ` Ajit Khaparde
2020-08-05 10:49 ` Andrew Rybchenko
2020-08-05 13:31 ` Dekel Peled
2020-08-05 13:44 ` Andrew Rybchenko
2020-08-05 14:25 ` Dekel Peled
2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
2020-08-06 12:25 ` Thomas Monjalon
2020-08-06 15:14 ` Andrew Rybchenko
2020-08-06 15:50 ` Ajit Khaparde
2020-08-06 21:57 ` Thomas Monjalon [this message]
2020-08-06 17:07 ` Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4140580.jaiIUUfkUx@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=asafp@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.