From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Anupam Kapoor <anupam.kapoor@gmail.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] kni : fix build errors for gcc --version >= 6.1
Date: Tue, 21 Jun 2016 17:53:30 +0200 [thread overview]
Message-ID: <4141088.RJFoBSLcMU@xps13> (raw)
In-Reply-To: <5769329F.1090407@intel.com>
2016-06-21 13:27, Ferruh Yigit:
> On 6/21/2016 12:43 PM, Anupam Kapoor wrote:
> > This commit fixes build errors triggered due misleading indentation.
> >
> > Fixes: 38db3f7f50bde (e1000: update base driver)
> Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline")
>
> > Fixes: 3fc5ca2f63529 (kni: initial import)
> >
> >
> > Signed-off-by: Anupam Kapoor <anupam.kapoor@gmail.com>
>
> Apart from above fixline update:
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
> Independent from this patch, for next patches, it would be helpful to
> maintainers and reviewers if
> - Add version number to new version of patches
> http://dpdk.org/doc/guides/contributing/patches.html#creating-patches
>
> - Send new versions in reply to old mail thread
> http://dpdk.org/doc/guides/contributing/patches.html#sending-patches
>
> - And in patchwork change status of old version of patch to superseded
> http://dpdk.org/dev/patchwork/project/dpdk/list/
I add:
- Use git send-email
(this patch was corrupted)
next prev parent reply other threads:[~2016-06-21 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 11:43 [PATCH] kni : fix build errors for gcc --version >= 6.1 Anupam Kapoor
2016-06-21 12:27 ` Ferruh Yigit
2016-06-21 15:53 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 8:37 Anupam Kapoor
2016-06-21 10:10 ` Ferruh Yigit
2016-06-21 11:20 ` Anupam Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4141088.RJFoBSLcMU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=anupam.kapoor@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.