Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

From: Przemek Socha <soprwa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "StDenis, Tom" <Tom.StDenis-5C7GfCeVMHo@public.gmane.org>,
	"Koenig,
	Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
Cc: "Zhou,
	David(ChunMing)" <David1.Zhou-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.
Date: Thu, 31 Jan 2019 18:31:22 +0100	[thread overview]
Message-ID: <4141754.D6MJ5NIKBA@eclipse> (raw)
In-Reply-To: <676b4805-fc73-245f-abd2-38e014248b61-5C7GfCeVMHo@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]

Dnia czwartek, 31 stycznia 2019 17:56:32 CET piszesz:

> In my experience only the last chunk of the patch is necessary.  Can you 
> try this without:
> 
> 
>  >> +	vm->bulk_moveable = false;
> 
> 
> Too?
> 
> Thanks,
> Tom

Sure.

I have applied only the last chunk of the patch on top of today's amd-staging-
drm-next pull:

> >> @@ -2772,6 +2773,9 @@  void amdgpu_vm_bo_rmv(struct amdgpu_device *adev,
> >> 
> >> 	struct amdgpu_vm_bo_base **base;
> >>
> >>
> >>
> >> 	if (bo) {
> >> 
> >> +		if (bo->tbo.resv == vm->root.base.bo->tbo.resv)
> >> +			vm->bulk_moveable = false;
> >> +
> >> 
> >> 		for (base = &bo_va->base.bo->vm_bo; *base;
> >> 		
> >> 		     base = &(*base)->next) {
> >> 			
> >> 			if (*base != &bo_va->base)

and it seems to be working as expected also. 

Thanks,
Przemek.

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx