From: Mark Ruijter <bridge@siennax.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>,
bridge@lists.osdl.org, netdev@premium.geo.yahoo.akadns.net,
Tommy Christensen <tommy.christensen@tpack.net>
Subject: Re: [Bridge] Problem in changed VLAN code can cause systems to hang.
Date: Fri, 10 Sep 2004 15:29:55 +0200 [thread overview]
Message-ID: <4141AC53.1000102@siennax.com> (raw)
In-Reply-To: <20040910061424.29657cf3@linux.site>
Stephen Hemminger wrote:
> Thanks Tommy, the vlan MII ioctl pass through was passing the wrong device.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> --
> diff -Nru a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> --- a/net/8021q/vlan_dev.c 2004-09-10 06:12:16 -07:00
> +++ b/net/8021q/vlan_dev.c 2004-09-10 06:12:16 -07:00
> @@ -772,7 +772,7 @@
> case SIOCGMIIREG:
> case SIOCSMIIREG:
> if (real_dev->do_ioctl && netif_device_present(real_dev))
> - err = real_dev->do_ioctl(dev, &ifrr, cmd);
> + err = real_dev->do_ioctl(real_dev, &ifrr, cmd);
> break;
>
> case SIOCETHTOOL:
>
I tested the patch and it fixes the problem as expected.
Mark.
--
next prev parent reply other threads:[~2004-09-10 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 13:16 [Bridge] Problem in changed VLAN code can cause systems to hang Mark Ruijter
2004-09-09 15:21 ` [Bridge] " David S. Miller
2004-09-09 15:33 ` shemminger
2004-09-09 15:51 ` David S. Miller
2004-09-10 11:56 ` Stephen Hemminger
2004-09-10 12:38 ` Tommy Christensen
2004-09-10 13:17 ` Stephen Hemminger
2004-09-10 13:02 ` Mark Ruijter
2004-09-09 15:54 ` Mark Ruijter
2004-09-09 16:00 ` Ben Greear
2004-09-09 15:34 ` Mark Ruijter
2004-09-10 12:43 ` [Bridge] " Tommy Christensen
2004-09-10 13:14 ` Stephen Hemminger
2004-09-10 13:29 ` Mark Ruijter [this message]
2004-09-10 23:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4141AC53.1000102@siennax.com \
--to=bridge@siennax.com \
--cc=bridge@lists.osdl.org \
--cc=davem@redhat.com \
--cc=netdev@premium.geo.yahoo.akadns.net \
--cc=shemminger@osdl.org \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.