From: Mario Limonciello <superm1@kernel.org>
To: Lars Francke <lars.francke@gmail.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Patil Rajesh <Patil.Reddy@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
platform-driver-x86@vger.kernel.org, "Kumar,
Rajesh (SW Driver)" <Rajesh1.Kumar@amd.com>
Subject: Re: AMD PMF: CCP PSP fails to reinitialize after hibernation causing TEE errors
Date: Wed, 22 Oct 2025 15:09:10 -0500 [thread overview]
Message-ID: <41429892-61f0-4ef4-aaa8-415bf64d0976@kernel.org> (raw)
In-Reply-To: <CAD-Ua_gfJnQSo8ucS_7ZwzuhoBRJ14zXP7s8b-zX3ZcxcyWePw@mail.gmail.com>
On 10/22/25 3:04 PM, Lars Francke wrote:
> Hi,
>
> while I've been active in the open-source ecosystem for years, this is
> my first report to the kernel. Please be gentle if I made mistakes.
>
> I'm debugging hibernation & sleep issues with my HP ZBook Ultra G1a.
> It has a AMD RYZEN AI MAX+ PRO 395 w/ Radeon 8060S.
>
> After resuming from hibernation I get this log line once a second:
> amd-pmf AMDI0105:00: TEE enact cmd failed. err: ffff000e, ret:0
>
> Right after hibernation and before the first of those errors I get:
> ccp 0000:c3:00.2: tee: command 0x5 timed out, disabling PSP
>
> On boot it looks good:
> ccp 0000:c3:00.2: psp enabled
>
> I had to google what TEE, CCP and PSP mean so it's partial guesswork
> on my end that these are related. It looks like PSP hardware(?)
> doesn't come out of hibernation properly and is disabled which means
> all further calls to it fail and I get the error message.
> It looks scary but seems harmless?
>
> Commit 11e298f3548a6fe5e6ad78f811abfba15e6ebbc1 from 2024 has
> more or less exactly my error message but it doesn't seem
> to be fixed for this case.
> https://lore.kernel.org/all/20240216064112.962582-2-Shyam-sundar.S-k@amd.com/
> (I picked my recipients partially from that mail & maintainers.pl output)
>
> My Environment
> - Kernel: 6.17.4-arch2-1
> - Hardware: HP ZBook Ultra G1a with AMD Ryzen AI Max+ Pro 395
> - Distribution: Arch Linux
>
> I can (try to) test patches and provide additional debug output if needed.
> I have not tried any of the 6.18 RCs yet but I'll try to figure out
> how I can install them next. Looking at the git history I can't
> see any changes between 6.17.4 and 6.18 that seem relevant though.
>
> Thanks for your help!
>
> Cheers,
> Lars
>
Thanks for the report!
Right now the PMF driver runs the same code during suspend/resume and
hibernate/resume (there are common callbacks).
However different things happen to the platform during suspend/resume
and hibernate/resume.
In suspend/resume the TA that was loaded into the TEE environment
continues to be loaded.
In hibernate/resume the system will lose all context and the TA is no
longer loaded.
So I feel the correct solution here is to add a dedicated restore()
callback which reloads the TA before going down the common path.
next prev parent reply other threads:[~2025-10-22 20:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 20:04 AMD PMF: CCP PSP fails to reinitialize after hibernation causing TEE errors Lars Francke
2025-10-22 20:09 ` Mario Limonciello [this message]
2025-10-26 14:17 ` Shyam Sundar S K
2025-10-26 16:46 ` Lars Francke
2025-10-26 16:49 ` Shyam Sundar S K
2025-10-26 17:40 ` Mario Limonciello
2025-10-26 17:44 ` Mario Limonciello
2025-10-26 20:39 ` Lars Francke
2025-10-26 21:16 ` Mario Limonciello
2025-10-26 23:21 ` Lars Francke
2025-10-27 2:15 ` Mario Limonciello
2025-10-27 11:12 ` Lars Francke
2025-10-27 12:11 ` Shyam Sundar S K
2025-10-27 13:10 ` Mario Limonciello
2025-10-27 16:18 ` Lars Francke
2025-10-27 19:32 ` Mario Limonciello
2025-10-27 20:17 ` Lars Francke
2025-10-27 20:40 ` Mario Limonciello
2025-10-27 20:46 ` Lars Francke
2025-10-27 21:23 ` Lars Francke
2025-10-28 17:12 ` Shyam Sundar S K
2025-10-28 23:45 ` Lars Francke
2025-10-29 3:38 ` Mario Limonciello (AMD) (kernel.org)
2025-10-30 0:22 ` Lars Francke
2025-10-30 13:35 ` Mario Limonciello (AMD) (kernel.org)
2025-11-04 16:16 ` Mario Limonciello
2025-11-11 8:56 ` Lars Francke
2025-11-19 21:07 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41429892-61f0-4ef4-aaa8-415bf64d0976@kernel.org \
--to=superm1@kernel.org \
--cc=Patil.Reddy@amd.com \
--cc=Rajesh1.Kumar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=john.allen@amd.com \
--cc=lars.francke@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.