From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CD5245002 for ; Fri, 14 Feb 2025 16:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739551771; cv=none; b=UHVSBkxKstH4oY90Qfulp/TTIvJG2AZ/eXNNWBvNTga3y8R8NdsIVYbKR07ES8dye9NOwsPZBJzh6BErq5gejQwfZUSy/+FIjnH8J9V+nsiFmKzbEL40aS/UkiqvxLv8yB4vjLaqhimNFrOHbl7c2jz61uhtRJHgSc5Blqu0aF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739551771; c=relaxed/simple; bh=pLOvI29Aapj4IwnfzZBqEbDiMXSI4ItjPkzJDZfHXao=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=fbDmEwYRRc8+4MvF6LPAT5CTz2oIp2kHkNjPmBX6phjwoIdXRytucurlE/B9I8lzO8n4iXSW43OW1N+yAmUgrSrVNLqPC17qtVV83qGMoMaszUWJfjk96QzOhSaK3H/7v8OS2w8xrS87n7jRGhohMCr8wtQruoEU0PXCdMqF1eU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XubBJHf+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XubBJHf+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739551768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RFZJfEhydfL+zGFnhFKg82fdmsgRH1RPROwECxkAuWw=; b=XubBJHf+iPWVZyMCDyRUbnmjxw0ypQtKgTnFsaPX2T5pfXX0WanODdP0R6lZNpgGPM67jm kAG3oQ8aJL3i4IacNrNiQdNsAAXNf5cy1HLN9NEyB9qP4gPdI3Rmc8KNpK8YP7ZB1DDOoa 8Dgpz5Bf8JXQHHOD9jvSjJvdTRZxwbk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-F9ck2ihFP4yWtSgUlgZjZQ-1; Fri, 14 Feb 2025 11:49:27 -0500 X-MC-Unique: F9ck2ihFP4yWtSgUlgZjZQ-1 X-Mimecast-MFC-AGG-ID: F9ck2ihFP4yWtSgUlgZjZQ_1739551765 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7577E180087D; Fri, 14 Feb 2025 16:49:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.92]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C169519373C4; Fri, 14 Feb 2025 16:49:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Eric Sandeen Cc: dhowells@redhat.com, linux-fsdevel , Lukas Schauer Subject: Re: [RFC PATCH 2/2] watch_queue: Fix pipe accounting Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4145091.1739551762.1@warthog.procyon.org.uk> Date: Fri, 14 Feb 2025 16:49:22 +0000 Message-ID: <4145092.1739551762@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Eric Sandeen wrote: > - if (!pipe_has_watch_queue(pipe)) { > - pipe->max_usage = nr_slots; > - pipe->nr_accounted = nr_slots; > - } > + pipe->max_usage = nr_slots; > + pipe->nr_accounted = nr_slots; Hmmm... The pipe ring is supposed to have some spare capacity when used as a watch queue so that you can bung at least a few messages into it. David