From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sata_svw: Fix __iomem related warnings
Date: Mon, 13 Sep 2004 09:19:42 -0400 [thread overview]
Message-ID: <41459E6E.9020902@pobox.com> (raw)
In-Reply-To: <20040913093628.A24406@infradead.org>
Christoph Hellwig wrote:
> On Mon, Sep 13, 2004 at 02:27:22PM +1000, Benjamin Herrenschmidt wrote:
>
>>This patch adds some (ugly) casts to sata_svw to remove the
>>warnings generated by the new iomem stuff.
>
>
> Umm, maybe it's just me - but shouldn't you fix them properly?
>
>
>>- writeb(tf->ctl, ioaddr->ctl_addr);
>>+ writeb(tf->ctl, (void __iomem *)ioaddr->ctl_addr);
>
>
> e.g. ioaddr->ctl_addr should get a __iomem attribute
Wrong. Read the code.
Jeff
prev parent reply other threads:[~2004-09-13 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 4:27 [PATCH] sata_svw: Fix __iomem related warnings Benjamin Herrenschmidt
2004-09-13 8:36 ` Christoph Hellwig
2004-09-13 13:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41459E6E.9020902@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.