From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Whitwell <keith@tungstengraphics.com>
Date: Thu, 16 Sep 2004 07:09:49 +0000
Subject: [Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:
Message-Id: <41493C3D.6090403@tungstengraphics.com>
List-Id: <kernel-janitors.vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

Nishanth Aravamudan wrote:
> Any comments would be appreciated. 
> 
> Description: Use set_current_state() instead of direct assignment of
> current->state.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/drm_os_linux.h	2004-09-09 23:05:38.000000000 -0700
> +++ 2.6.9-rc1-mm4/drivers/char/drm/drm_os_linux.h	2004-09-10 10:34:04.000000000 -0700
> @@ -134,7 +134,7 @@ do {								\
>  	add_wait_queue(&(queue), &entry);			\
>  								\
>  	for (;;) {						\
> -		current->state = TASK_INTERRUPTIBLE;		\
> +		set_current_state(TASK_INTERRUPTIBLE);		\
>  		if (condition)					\
>  			break;					\
>  		if (time_after_eq(jiffies, end)) {		\
> 

There are two assignments in that macro, aren't there?  Why not adjust both of 
them?

Keith
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors