All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: Netfilter-devel <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 2/2] Cleanup returnvalues of protocolhandlers
Date: Sun, 19 Sep 2004 22:41:20 +0200	[thread overview]
Message-ID: <414DEEF0.8020508@trash.net> (raw)
In-Reply-To: <1095597972.8380.16.camel@tux.rsn.bth.se>

Martin Josefsson wrote:

>Hi Patrick
>
>Here's the second of two patches based on Pablo Neiras patch.
>
>This adds new defines to be returned from conntrack protocol modules in
>order to make it clear what they want. Most importantly, they get rid of
>the confusing mixing of positive and negative returnvalues.
>  
>
A couple of conversion where missing in ip_conntrack_proto_icmp.c,
I've added them to the patch. BTW: shouldn't we return CONNTRACK_INVALID
for all invalid icmp packets ? icmp_error returns CONNTRACK_INVALID for
these packets, icmp_error_message (after simple 1:1 conversion) returns
CONNTRACK_CONT.

Regards
Patrick

  reply	other threads:[~2004-09-19 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-19 12:46 [PATCH 2/2] Cleanup returnvalues of protocolhandlers Martin Josefsson
2004-09-19 20:41 ` Patrick McHardy [this message]
2004-09-19 20:42   ` Patrick McHardy
2004-09-20  9:11     ` Martin Josefsson
2004-09-20  8:11 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414DEEF0.8020508@trash.net \
    --to=kaber@trash.net \
    --cc=gandalf@wlug.westbo.se \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.