From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42278 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934971AbeBMMpK (ORCPT ); Tue, 13 Feb 2018 07:45:10 -0500 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, Simon Horman , Kieran Bingham , Kieran Bingham , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list Subject: Re: [PATCH 4/4] arm64: dts: renesas: r8a77995: add VSPD instances Date: Tue, 13 Feb 2018 14:45:41 +0200 Message-ID: <4151746.tevFeqBdEH@avalon> In-Reply-To: <1518474330-8713-5-git-send-email-kbingham@kernel.org> References: <1518474330-8713-1-git-send-email-kbingham@kernel.org> <1518474330-8713-5-git-send-email-kbingham@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:29 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has two VSPDs to handle display pipelines with a DU. > > Signed-off-by: Kieran Bingham > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > 50c891f6649f..2c14a8dfd201 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -711,6 +711,16 @@ > iommus = <&ipmmu_vp0 5>; > }; > > + vspd0: vsp@fea20000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfea20000 0 0x4000>; Same issue as in patch 3/4 (for which I have incorrectly mentioned VSPD instead of VSPBS). I'd just extend the region size to 0x8000 for both VSPDs. Apart from that, Reviewed-by: Laurent Pinchart > + interrupts = ; > + clocks = <&cpg CPG_MOD 623>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 623>; > + renesas,fcp = <&fcpvd0>; > + }; > + > fcpvd0: fcp@fea27000 { > compatible = "renesas,fcpv"; > reg = <0 0xfea27000 0 0x200>; > @@ -720,6 +730,16 @@ > iommus = <&ipmmu_vi0 8>; > }; > > + vspd1: vsp@fea80000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfea28000 0 0x4000>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 622>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 622>; > + renesas,fcp = <&fcpvd1>; > + }; > + > fcpvd1: fcp@fea2f000 { > compatible = "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 13 Feb 2018 14:45:41 +0200 Subject: [PATCH 4/4] arm64: dts: renesas: r8a77995: add VSPD instances In-Reply-To: <1518474330-8713-5-git-send-email-kbingham@kernel.org> References: <1518474330-8713-1-git-send-email-kbingham@kernel.org> <1518474330-8713-5-git-send-email-kbingham@kernel.org> Message-ID: <4151746.tevFeqBdEH@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:29 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has two VSPDs to handle display pipelines with a DU. > > Signed-off-by: Kieran Bingham > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > 50c891f6649f..2c14a8dfd201 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -711,6 +711,16 @@ > iommus = <&ipmmu_vp0 5>; > }; > > + vspd0: vsp at fea20000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfea20000 0 0x4000>; Same issue as in patch 3/4 (for which I have incorrectly mentioned VSPD instead of VSPBS). I'd just extend the region size to 0x8000 for both VSPDs. Apart from that, Reviewed-by: Laurent Pinchart > + interrupts = ; > + clocks = <&cpg CPG_MOD 623>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 623>; > + renesas,fcp = <&fcpvd0>; > + }; > + > fcpvd0: fcp at fea27000 { > compatible = "renesas,fcpv"; > reg = <0 0xfea27000 0 0x200>; > @@ -720,6 +730,16 @@ > iommus = <&ipmmu_vi0 8>; > }; > > + vspd1: vsp at fea80000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfea28000 0 0x4000>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 622>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 622>; > + renesas,fcp = <&fcpvd1>; > + }; > + > fcpvd1: fcp at fea2f000 { > compatible = "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/4] arm64: dts: renesas: r8a77995: add VSPD instances Date: Tue, 13 Feb 2018 14:45:41 +0200 Message-ID: <4151746.tevFeqBdEH@avalon> References: <1518474330-8713-1-git-send-email-kbingham@kernel.org> <1518474330-8713-5-git-send-email-kbingham@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1518474330-8713-5-git-send-email-kbingham-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kieran Bingham Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Simon Horman , Kieran Bingham , Kieran Bingham , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list List-Id: devicetree@vger.kernel.org Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:29 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has two VSPDs to handle display pipelines with a DU. > > Signed-off-by: Kieran Bingham > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > 50c891f6649f..2c14a8dfd201 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -711,6 +711,16 @@ > iommus = <&ipmmu_vp0 5>; > }; > > + vspd0: vsp@fea20000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfea20000 0 0x4000>; Same issue as in patch 3/4 (for which I have incorrectly mentioned VSPD instead of VSPBS). I'd just extend the region size to 0x8000 for both VSPDs. Apart from that, Reviewed-by: Laurent Pinchart > + interrupts = ; > + clocks = <&cpg CPG_MOD 623>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 623>; > + renesas,fcp = <&fcpvd0>; > + }; > + > fcpvd0: fcp@fea27000 { > compatible = "renesas,fcpv"; > reg = <0 0xfea27000 0 0x200>; > @@ -720,6 +730,16 @@ > iommus = <&ipmmu_vi0 8>; > }; > > + vspd1: vsp@fea80000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfea28000 0 0x4000>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 622>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 622>; > + renesas,fcp = <&fcpvd1>; > + }; > + > fcpvd1: fcp@fea2f000 { > compatible = "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html