All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Seyfried <seife@suse.de>
To: linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc2-mm2
Date: Wed, 22 Sep 2004 23:02:43 +0200	[thread overview]
Message-ID: <4151E873.9020308@suse.de> (raw)
In-Reply-To: <20040922131210.6c08b94c.akpm@osdl.org>

Hi,

Andrew Morton wrote:

> swsusp-fix-highmem.patch
>   swsusp: fix highmem

this one should actually be

@@ -854,8 +854,10 @@ int swsusp_suspend(void)
  	local_irq_disable();
  	save_processor_state();
  	error = swsusp_arch_suspend();
+	/* Restore control flow magically appears here */
  	restore_processor_state();
+	restore_highmem();
  	local_irq_enable();
  	return error;

so that local_irq_enable() is _after_ restore_highmem(). It took Pavel 
and me quite some time to debug the mysterious crashes on some highmem 
machines...

     Stefan


  parent reply	other threads:[~2004-09-22 21:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-22 20:12 2.6.9-rc2-mm2 Andrew Morton
2004-09-22 20:48 ` 2.6.9-rc2-mm2 Jesse Barnes
2004-09-22 20:54   ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-22 21:05     ` 2.6.9-rc2-mm2 Jesse Barnes
2004-09-22 20:55   ` 2.6.9-rc2-mm2 William Lee Irwin III
2004-09-22 20:59   ` 2.6.9-rc2-mm2 Jesse Barnes
2004-09-22 21:04     ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-22 21:10       ` 2.6.9-rc2-mm2 Jesse Barnes
2004-09-22 21:02 ` Stefan Seyfried [this message]
2004-09-22 22:27 ` 2.6.9-rc2-mm2 Peter Williams
2004-09-23  1:47 ` 2.6.9-rc2-mm2 Nuno Ferreira
2004-09-23  2:03   ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-23  2:58     ` 2.6.9-rc2-mm2 Herbert Xu
2004-09-23  9:29       ` 2.6.9-rc2-mm2 Nuno Ferreira
2004-09-23  3:00 ` 2.6.9-rc2-mm2 Nick Piggin
2004-09-23  5:07 ` 2.6.9-rc2-mm2 William Lee Irwin III
2004-09-23  5:27   ` 2.6.9-rc2-mm2 William Lee Irwin III
2004-09-23  5:46   ` 2.6.9-rc2-mm2 Peter Williams
2004-09-23  6:01     ` 2.6.9-rc2-mm2 William Lee Irwin III
2004-09-23 13:15 ` 2.6.9-rc2-mm2 Vladimir Saveliev
2004-09-23 15:51   ` 2.6.9-rc2-mm2 (disable repacker) Mike Houston
2004-09-23 16:48 ` 2.6.9-rc2-mm2 William Lee Irwin III
2004-09-23 17:59 ` 2.6.9-rc2-mm2 Akinobu Mita
2004-09-24  0:53 ` 2.6.9-rc2-mm2 [u] Martin Schlemmer [c]
2004-10-02  7:44 ` 2.6.9-rc2-mm2 Jaakko Hyvätti
2004-10-02  7:49   ` 2.6.9-rc2-mm2 Andrew Morton
2004-10-02 18:21     ` 2.6.9-rc2-mm2 Jaakko Hyvätti
2004-10-08 11:24     ` 2.6.9-rc2-mm2 William Lee Irwin III
     [not found] <747804697@toto.iv>
2004-09-23  0:39 ` 2.6.9-rc2-mm2 Peter Chubb
2004-09-23  0:43   ` 2.6.9-rc2-mm2 Jesse Barnes
2004-09-23  6:23     ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-23  6:23       ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-23 16:10       ` 2.6.9-rc2-mm2 Luck, Tony
2004-09-23 16:10         ` 2.6.9-rc2-mm2 Luck, Tony
2004-09-23 18:31         ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-23 18:31           ` 2.6.9-rc2-mm2 Andrew Morton
2004-09-23  0:49   ` 2.6.9-rc2-mm2 Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2004-09-24  6:27 2.6.9-rc2-mm2 Tim Krieglstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4151E873.9020308@suse.de \
    --to=seife@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.