From: Arnd Bergmann <arnd@arndb.de>
To: Michael Welling <mwelling@ieee.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>,
Felipe Balbi <balbi@ti.com>, Sebastian Reichel <sre@kernel.org>,
Roger Quadros <rogerq@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004
Date: Thu, 29 Oct 2015 22:46:20 +0100 [thread overview]
Message-ID: <4152426.STHOuGxqsW@wuerfel> (raw)
In-Reply-To: <20151029142237.GA11531@qwerty.qwertyembedded>
On Thursday 29 October 2015 09:22:37 Michael Welling wrote:
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/built-in.o: In function `tsc2005_cmd':
> > >> tsc200x-core.c:(.text+0x2ae07f): undefined reference to `i2c_smbus_write_byte'
>
> Argh!
>
> How do I fix this one?
>
Move all the I2C specific code into the tsc2004.c file and remove the
#ifdef. The problem is that tsc200x-core.c is used as built-in when
TOUCHSCREEN_TSC2005=y and I2C=m, so it can't call functions that are
defined in i2c-core.c.
Arnd
next prev parent reply other threads:[~2015-10-29 21:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 0:12 [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling
2015-10-29 0:12 ` Michael Welling
2015-10-29 7:25 ` kbuild test robot
2015-10-29 7:25 ` kbuild test robot
2015-10-29 14:22 ` Michael Welling
2015-10-29 21:46 ` Arnd Bergmann [this message]
2015-10-29 21:53 ` Michael Welling
2015-10-29 22:23 ` Dmitry Torokhov
2015-10-30 0:39 ` Mark Brown
2015-10-30 1:01 ` Michael Welling
[not found] ` <20151030010151.GA4196-hEWAmvUofr51knWWc6b7UDvvZPQxeRhI@public.gmane.org>
2015-10-30 10:40 ` Arnd Bergmann
2015-10-30 10:40 ` Arnd Bergmann
2015-10-30 1:45 ` Dmitry Torokhov
2015-10-30 2:08 ` Michael Welling
2015-10-30 2:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4152426.STHOuGxqsW@wuerfel \
--to=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mwelling@ieee.org \
--cc=pavel@ucw.cz \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.