From: Jonathan Derrick <jonathan.derrick@linux.dev>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Nirmal Patel <nirmal.patel@linux.intel.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: vmd: Use preferred header files linux/device.h and linux/msi.h
Date: Thu, 14 Oct 2021 12:05:19 -0600 [thread overview]
Message-ID: <4152471b-fdc9-5cfa-b72d-97f62fe4d282@linux.dev> (raw)
In-Reply-To: <20211013003145.1107148-1-kw@linux.com>
On 10/12/2021 6:31 PM, Krzysztof Wilczyński wrote:
> Use the preferred generic header files linux/device.h and linux/msi.h
> that already include the corresponding asm/device.h and asm/msi.h files,
> especially where the headers files linux/msi.h and asm/msi.h where both
> included.
>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
> drivers/pci/controller/vmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index a5987e52700e..9609eb911349 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -9,6 +9,7 @@
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/device.h>
> #include <linux/msi.h>
> #include <linux/pci.h>
> #include <linux/pci-acpi.h>
> @@ -18,8 +19,6 @@
> #include <linux/rcupdate.h>
>
> #include <asm/irqdomain.h>
> -#include <asm/device.h>
> -#include <asm/msi.h>
>
> #define VMD_CFGBAR 0
> #define VMD_MEMBAR1 2
>
Reviewed-by: Jonathan Derrick <jonathan.derrick@linux.dev>
next prev parent reply other threads:[~2021-10-14 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 0:31 [PATCH 1/2] PCI: vmd: Use preferred header files linux/device.h and linux/msi.h Krzysztof Wilczyński
2021-10-13 0:31 ` [PATCH 2/2] PCI: hotplug: Use preferred header file linux/io.h Krzysztof Wilczyński
2021-10-14 18:06 ` Jonathan Derrick
2021-10-14 18:05 ` Jonathan Derrick [this message]
2021-11-02 19:45 ` [PATCH 1/2] PCI: vmd: Use preferred header files linux/device.h and linux/msi.h Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4152471b-fdc9-5cfa-b72d-97f62fe4d282@linux.dev \
--to=jonathan.derrick@linux.dev \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.