From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH 2.6.9-rc2 22/38] net/ltpc: replace
Date: Thu, 23 Sep 2004 22:27:25 +0000 [thread overview]
Message-ID: <41534DCD.3000800@conectiva.com.br> (raw)
In-Reply-To: <20040916234647.GI1777@us.ibm.com>
Nishanth Aravamudan wrote:
> Any comments would be appreciated.
OK with me, as the other one for the cyc2x
>
> Description: Use ssleep() / msleep() [as appropriate]
> instead of schedule_timeout() to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.9-rc2-vanilla/drivers/net/appletalk/ltpc.c 2004-09-13 17:15:44.000000000 -0700
> +++ 2.6.9-rc2/drivers/net/appletalk/ltpc.c 2004-09-14 17:11:33.000000000 -0700
> @@ -1109,8 +1109,7 @@ struct net_device * __init ltpc_probe(vo
> inb_p(io+1);
> inb_p(io+3);
>
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(2*HZ/100);
> + msleep(20);
>
> inb_p(io+0);
> inb_p(io+2);
> @@ -1120,8 +1119,7 @@ struct net_device * __init ltpc_probe(vo
> inb_p(io+5); /* enable dma */
> inb_p(io+6); /* tri-state interrupt line */
>
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(HZ);
> + ssleep(1);
>
> /* now, figure out which dma channel we're using, unless it's
> already been specified */
>
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-09-23 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
2004-09-21 22:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir: Jean Tourrilhes
2004-09-21 23:49 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/2] i2c/i2c-mpc: replace Greg KH
2004-09-22 9:58 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] message/exec-osm: Markus Lidel
2004-09-23 22:27 ` Arnaldo Carvalho de Melo [this message]
2004-09-24 18:21 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace Nishanth Aravamudan
2004-09-28 0:40 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 26/38] net/orinoco_plx: David Gibson
2004-09-28 22:23 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl: David S. Miller
2004-09-29 17:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp: Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41534DCD.3000800@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.