From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [sparc64] fio bus error References: <2dffb54c-6f7d-5a3b-8b47-54cba6dd6039@kernel.dk> From: Jens Axboe Message-ID: <4155a143-a703-2eed-776e-9766dcd87d86@kernel.dk> Date: Mon, 22 Aug 2016 13:24:13 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Anatoly Pugachev Cc: fio@vger.kernel.org, sparclinux@vger.kernel.org, debian-sparc List-ID: On 08/22/2016 01:17 PM, Anatoly Pugachev wrote: > On Mon, Aug 22, 2016 at 8:32 PM, Jens Axboe wrote: >> On 08/20/2016 09:19 AM, Anatoly Pugachev wrote: >>> Thread 2 "fio" received signal SIGBUS, Bus error. >>> [Switching to Thread 0xffff80011025b910 (LWP 15753)] >>> calc_log_samples () at stat.c:2461 >>> 2461 tmp = add_bw_samples(td, &now); >>> (gdb) bt >>> #0 calc_log_samples () at stat.c:2461 >>> #1 0x000000000018e944 in helper_thread_main (data=0xffff800100ac5670) >>> at helper_thread.c:121 >>> #2 0xffff80010063ba04 in start_thread (arg=0xffff80011025b910) at >>> pthread_create.c:335 >>> #3 0xffff800100944f58 in __thread_start () at >>> ../sysdeps/unix/sysv/linux/sparc/sparc64/clone.S:93 >>> Backtrace stopped: previous frame identical to this frame (corrupt stack?) >>> (gdb) >> >> >> Does this help? >> >> diff --git a/stat.c b/stat.c >> index 552d88dde067..74c2686c660c 100644 >> --- a/stat.c >> +++ b/stat.c >> @@ -2457,12 +2457,12 @@ int calc_log_samples(void) >> next = min(td->o.iops_avg_time, td->o.bw_avg_time); >> continue; >> } >> - if (!per_unit_log(td->bw_log)) { >> + if (td->bw_log && !per_unit_log(td->bw_log)) { >> tmp = add_bw_samples(td, &now); >> if (tmp < next) >> next = tmp; >> } >> - if (!per_unit_log(td->iops_log)) { >> + if (td->iops_log && !per_unit_log(td->iops_log)) { >> tmp = add_iops_samples(td, &now); >> if (tmp < next) >> next = tmp; >> > > > Jens, > > yes, this patch fixed sigbus. Thanks. Great, thanks for reporting. I have committed the fix. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Mon, 22 Aug 2016 19:24:13 +0000 Subject: Re: [sparc64] fio bus error Message-Id: <4155a143-a703-2eed-776e-9766dcd87d86@kernel.dk> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org On 08/22/2016 01:17 PM, Anatoly Pugachev wrote: > On Mon, Aug 22, 2016 at 8:32 PM, Jens Axboe wrote: >> On 08/20/2016 09:19 AM, Anatoly Pugachev wrote: >>> Thread 2 "fio" received signal SIGBUS, Bus error. >>> [Switching to Thread 0xffff80011025b910 (LWP 15753)] >>> calc_log_samples () at stat.c:2461 >>> 2461 tmp = add_bw_samples(td, &now); >>> (gdb) bt >>> #0 calc_log_samples () at stat.c:2461 >>> #1 0x000000000018e944 in helper_thread_main (data=0xffff800100ac5670) >>> at helper_thread.c:121 >>> #2 0xffff80010063ba04 in start_thread (arg=0xffff80011025b910) at >>> pthread_create.c:335 >>> #3 0xffff800100944f58 in __thread_start () at >>> ../sysdeps/unix/sysv/linux/sparc/sparc64/clone.S:93 >>> Backtrace stopped: previous frame identical to this frame (corrupt stack?) >>> (gdb) >> >> >> Does this help? >> >> diff --git a/stat.c b/stat.c >> index 552d88dde067..74c2686c660c 100644 >> --- a/stat.c >> +++ b/stat.c >> @@ -2457,12 +2457,12 @@ int calc_log_samples(void) >> next = min(td->o.iops_avg_time, td->o.bw_avg_time); >> continue; >> } >> - if (!per_unit_log(td->bw_log)) { >> + if (td->bw_log && !per_unit_log(td->bw_log)) { >> tmp = add_bw_samples(td, &now); >> if (tmp < next) >> next = tmp; >> } >> - if (!per_unit_log(td->iops_log)) { >> + if (td->iops_log && !per_unit_log(td->iops_log)) { >> tmp = add_iops_samples(td, &now); >> if (tmp < next) >> next = tmp; >> > > > Jens, > > yes, this patch fixed sigbus. Thanks. Great, thanks for reporting. I have committed the fix. -- Jens Axboe