From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 17/32] drm/exynos: Add mode_set manager operation
Date: Sun, 10 Nov 2013 22:31:59 +0100
Message-ID: <4157242.0JpQk7nWfH@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<1383063198-10526-18-git-send-email-seanpaul@chromium.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52])
	by gabe.freedesktop.org (Postfix) with ESMTP id AC3F6FA685
	for <dri-devel@lists.freedesktop.org>;
	Sun, 10 Nov 2013 22:34:58 -0800 (PST)
Received: by mail-ee0-f52.google.com with SMTP id l10so470483eei.39
	for <dri-devel@lists.freedesktop.org>;
	Sun, 10 Nov 2013 22:34:57 -0800 (PST)
In-Reply-To: <1383063198-10526-18-git-send-email-seanpaul@chromium.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org
List-Id: dri-devel@lists.freedesktop.org

Hi Sean,

On Tuesday 29 of October 2013 12:13:03 Sean Paul wrote:
> This patch adds a mode_set callback to the manager operations which
> sets the crtc's current mode to the manager driver.

To allow/fix/improve/extend...

Patch description should say why such change is good to have.

> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> 
> Changes in v2: None
> Changes in v3: None
> 
>  drivers/gpu/drm/exynos/exynos_drm_crtc.c | 4 ++++
>  drivers/gpu/drm/exynos/exynos_drm_drv.h  | 3 +++
>  2 files changed, 7 insertions(+)

Otherwise the patch looks fine.

Best regards,
Tomasz