From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Subject: Re: [PATCH] convert mport to multiport Date: Mon, 27 Sep 2004 01:50:20 +0200 Sender: netfilter-devel-bounces@lists.netfilter.org Message-ID: <415755BC.8000706@eurodev.net> References: <415748E8.60000@eurodev.net> <41574F5E.1020409@eurodev.net> <41575282.4030006@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Development Mailinglist Return-path: To: Patrick McHardy In-Reply-To: <41575282.4030006@trash.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Hi Patrick, Patrick McHardy wrote: >>> +/* every entry in ports[] except for the last one has one bit in >>> pflags >>> + * associated with it. If this bit is set, the port is the first >>> port of >>> + * a portrange, with the next entry being the last. >>> + * End of list is marked with pflags bit set and port=65535. >>> + * If 14 ports are used (last one does not have a pflag), the last >>> port >>> + * is repeated to fill the last entry in ports[] */ >>> struct ipt_multiport >>> { >>> - u_int8_t flags; /* Type of comparison */ >>> - u_int8_t count; /* Number of ports */ >>> + u_int8_t flags:2; /* Type of comparison */ >>> + u_int16_t pflags:14; /* Port flags */ >>> u_int16_t ports[IPT_MULTI_PORTS]; /* Ports */ >>> + u_int8_t count; /* Number of ports */ >>> >>> > > This breaks userspace compatibility. We can't do that, sorry. In that case, I have the patches without that change here, I'll test them and then I'll resend them to you again. regards, Pablo