From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] note owner match brokenness
Date: Fri, 01 Oct 2004 23:09:37 +0200
Sender: netfilter-devel-bounces@lists.netfilter.org
Message-ID: <415DC791.3060409@trash.net>
References: <20041001204447.GA30390@linuxace.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netfilter-devel@lists.netfilter.org
Return-path: <netfilter-devel-bounces@lists.netfilter.org>
To: Phil Oester <kernel@linuxace.com>
In-Reply-To: <20041001204447.GA30390@linuxace.com>
List-Unsubscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=unsubscribe>
List-Archive: </pipermail/netfilter-devel>
List-Post: <mailto:netfilter-devel@lists.netfilter.org>
List-Help: <mailto:netfilter-devel-request@lists.netfilter.org?subject=help>
List-Subscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=subscribe>
Errors-To: netfilter-devel-bounces@lists.netfilter.org
List-Id: netfilter-devel.vger.kernel.org

Phil Oester wrote:

>Someone recently complained in bugzilla that the note about owner
>match being broken on SMP took hours to find because it was in
>syslog instead of userspace.  Hopefully the below patch will
>save others some time.
>
>This closes bugzilla #244
>
If we warn in userspace, we should warn when then options are used
instead of in the helptext.

Regards
Patrick

>Phil
>
>
>  
>
>------------------------------------------------------------------------
>
>diff -ru ipt-orig/extensions/libipt_owner.c ipt-new/extensions/libipt_owner.c
>--- ipt-orig/extensions/libipt_owner.c	2004-06-14 15:02:17.000000000 -0700
>+++ ipt-new/extensions/libipt_owner.c	2004-10-01 13:36:50.779263920 -0700
>@@ -22,6 +22,7 @@
> "[!] --pid-owner processid  Match local pid\n"
> "[!] --sid-owner sessionid  Match local sid\n"
> "[!] --cmd-owner name       Match local command name\n"
>+"NOTE: pid, sid and command matching are broken on SMP\n"
> "\n",
> IPTABLES_VERSION);
> #else
>@@ -31,6 +32,7 @@
> "[!] --gid-owner groupid    Match local gid\n"
> "[!] --pid-owner processid  Match local pid\n"
> "[!] --sid-owner sessionid  Match local sid\n"
>+"NOTE: pid and sid matching are broken on SMP\n"
> "\n",
> IPTABLES_VERSION);
> #endif /* IPT_OWNER_COMM */
>  
>