From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mJLeH-0004sp-U7 for mharc-grub-devel@gnu.org; Thu, 26 Aug 2021 16:06:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJLeB-0004qc-4f for grub-devel@gnu.org; Thu, 26 Aug 2021 16:06:49 -0400 Received: from mout.gmx.net ([212.227.15.15]:60849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJLe8-00059o-RZ for grub-devel@gnu.org; Thu, 26 Aug 2021 16:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630008402; bh=UPyPRPP4NxOY5J72eJe2JxcU8UnERBbZDrr/aZWHYPI=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=jGIGcCSPb10cixNn0qa2CJyJrS9JB6MxIJBrjVUMSYzNyfMlI1/aq6JLp5Qlt51wj TDhFASg0awFslmIw3oAj1lFxb8CVnqOCmV7ICYz21ul20hCsUWqy2q+hBr6CW8fFbs 5eJNaSBCN0dqIoVDMYxloNtuZCse22OBB8HonNIk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.233.243]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhlKs-1mwn7y2v32-00dnMA for ; Thu, 26 Aug 2021 22:06:42 +0200 Date: Thu, 26 Aug 2021 22:07:29 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [grub-fs-tester.in] zisofs test looks unsuitable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: development@efficientek.com References: <26478360869664256672@scdbackup.webframe.org> In-Reply-To: <26478360869664256672@scdbackup.webframe.org> Message-Id: <4162360898493653930@scdbackup.webframe.org> X-Provags-ID: V03:K1:QlkJrRlvuyAZBzUB8GJYU14C8D3I9e1kFju9QnCRTuIEQXSpo38 KKfCgKMhd3RzlFZYu4ywo13mCbXClcXQNC1I2ljffVDNKXQlmBLCXMRwJ0AoVDhFsmysHH0 fW8tx22IsdS0GqTv+tbFK5lTDXp6GLgqtTH1Hn7VAle3y29PpgRiUHPDHI8ieAciUkk9GSO WIUa6KU0M+dxypY/HJ1Aw== X-UI-Out-Filterresults: notjunk:1;V03:K0:6veEyfny8zU=:bFWjKRHB/MtD1grRT19fu3 1+BGbKUvRBrhrN/uYk5yIY/iziVXfkREXN2j0+8dP5OChMNeKafjJcC6ocTEdyMf8/aT5s0oc 87JT3T5CUQzTqU4q8dxoRKEAolfZ1hvJJDUHt5Zi5lL4mmNDvyWWwv8ZckZpU3DM6zLegdSq7 jfG5q0thbhGKLZYCPvDlw9gin58mdApSl6RFPsnNyBBz51zL4335YhhQU6UgD+BdQ0K7bbzn7 1j1KoB8H5hYsK4IgcXlM/4dOSfh6RODBUU68KSi0CzclUwurRYrl8R5jIfUFfrqYaFDPO+Q27 84i7mJNi3aOIlmAji3biiL74DUhGHMVkasDevkG88uYR5HHr/1YwUmpa6A1dRKBQ4uQMQtPvw q4fJ5IFdZsiZV2he801aLQzE2vkVi2YSH4YfdN0WOU1wQghbrmEvgB0zLMRawOrBypR2IXtKb mlLl/7xdRjqXoA5BKYR/mzNYbr5GgKwUQxLckyDmT1tKEhb4JtYgLaBc6CihSUJeW5RuaYqAH M1b2QyBHsMSNtqTkd6GvaE2FMHcBTZShETyFnQBeKmSr5K2JBZzqGRL/KoWmy01JGSq7j+f+w 7H8KFAfzMss5t8bbvRXYkR1lWjT2bsDj4q8Py+sem44cDD9UjY3q2b4tqFvR3UsDHSd95QRCJ Tqzr69EceZOPQ3/wJdk+ShayLjZ7gX9CBCOyhXedQ5MgRPQhoxUIDkdRU+8XlxtfcJqRdkxn3 TL2EcQIUhHroQ9g6E89fQ3ya/Ct63jcLLBLiU1FcnY80qq4NPkJ6NODo51yPfxce1Kj9KP8mi tBiimTxBLr0LVPaQ3OH50BmacfpKi84imXGE6FcR1K3IEuItgNv5yU8yzj0NlXTX8JfpSDhbE 7b77+2MARdHE1DOlJh+amn9pF5+UpqsDbIddpNXMm9qy8ySwJza7U6MtdZFWJQ/nyeCwcngVV +8YvJn9K9iNMeUO5JkFnZ7HVAXa1SV1HO28Y+OfAaEBOhZoLj5WCdWEetQyL1g56u4dOxFTJh qs3K2zgC//mBKKvEbLnLmH8Uhh1mblnFv8J31t72iTEA+ItjIHDADcCFYHaJ+rPgJP96c/e1b 7ZTiapa46OTGy/y3Aawahcnrsk9NZta9KfD3LRb9Fh0JAakjxxArUTncA== Received-SPF: pass client-ip=212.227.15.15; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 20:06:49 -0000 Hi, i managed to get the ziso9660 test running with actual compression. ./grub-fs-tester ziso9660 now produces an ISO image but seems not to be happy with it. If i get it right then it sees the compressed size 1124519 of file "1.img" but expects its uncompressed size 5242879. Linux mount sees -rw-r--r-- 2 thomas thomas 5242879 Aug 26 21:52 1.img So grub-fstest.c CMD_LS seems not yet ready for dealing with zisofs. This is the change which brought me that far, including a draft for a commit message: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D The grub-fs-tester test "ziso9660" failed early with a xorriso error because it was not in the list of tests which tolerate at most 32 bytes of FSLABEL. The xorriso run of ziso9660 did not actually compress the data files becau= se the xorriso command for installing zisofs filters was applied before any files had populated the emerging ISO image. So add "ziso9660" where other ISO 9660 tests get a shorter FSLABEL and re-arrange the commands of the xorriso run to bring -add and -zisofs befor= e -set_filter_r. Signed-off-by: Thomas Schmitt diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index bfc425e1f..834c05728 100644 =2D-- a/tests/util/grub-fs-tester.in +++ b/tests/util/grub-fs-tester.in @@ -314,7 +314,8 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSEC= SIZE" 1); do FSLABEL=3D"grub_;/test=C3=A9=D1=82i u=F0=9F=98=81=F0=AF=A6=9D=F0=AF= =A6=99=D0=BA=D0=B8=D1=80=D0=B8rewfceniuewruevrewnuuireurevueurnievrewfne";= ; # FS LIMITATION: afs and iso9660 label is at most 32 UTF-8 = characters x"afs" | xiso9660 | xrockridge | xrockridge_joliet\ - | xiso9660_1999 | xrockridge_1999 | xrockridge_jolie= t_1999) + | xiso9660_1999 | xrockridge_1999\ + | xrockridge_joliet_1999 | xziso9660) FSLABEL=3D"gr_;/=C3=A9=F0=AF=A6=9B=F0=AF=A6=9D=F0=9F=98=81=D0=BA= =D0=B8=D1=80=D0=B8=D1=82 u";; # FS LIMITATION: bfs label is at most 32 UTF-8 characters # OS LIMITATION: bfs label can't contain ; or / @@ -1020,7 +1021,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGS= ECSIZE" 1); do (cd "$MASTER"; find . | cpio -o -H "$(echo ${fs} | sed 's@^cpio_@@'= )" > "${FSIMAGEP}0.img" ) ;; x"ziso9660") FSUUID=3D$(date -u +%Y-%m-%d-%H-%M-%S-00); - xorriso -compliance rec_mtime -set_filter_r --zisofs -- -zisofs def= ault -as mkisofs -iso-level 3 -graft-points -R -J -joliet-long -V "$FSLABE= L" --modification-date=3D$(echo ${FSUUID} | sed 's/-//g;') -o "${FSIMAGEP}= 0.img" -- -set_filter_r --zisofs -- -zisofs default -add /=3D"$MASTER" ;; + xorriso -compliance rec_mtime -as mkisofs -iso-level 3 -graft-point= s -R -J -joliet-long -V "$FSLABEL" --modification-date=3D$(echo ${FSUUID} = | sed 's/-//g;') -o "${FSIMAGEP}0.img" -- -add /=3D"$MASTER" -- -zisofs de= fault -set_filter_r --zisofs / -- ;; x"iso9660") FSUUID=3D$(date -u +%Y-%m-%d-%H-%M-%S-00); xorriso --rockridge off -compliance rec_mtime -as mkisofs -iso-leve= l 3 -graft-points -V "$FSLABEL" --modification-date=3D$(echo ${FSUUID} | s= ed 's/-//g;') -o "${FSIMAGEP}0.img" /=3D"$MASTER" ;; =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D Here is a run with this change: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D $ ./grub-fs-tester ziso9660 GNU xorriso 1.5.4.pl02 : RockRidge filesystem manipulator, libburnia proje= ct. Drive current: -outdev 'stdio:/tmp/tmp.iIXC5zIfEd/ziso9660_512_512_1_0.img= ' Media current: stdio file, overwriteable Media status : is blank Media summary: 0 sessions, 0 data blocks, 0 data, 400g free xorriso : WARNING : -volid text problematic as automatic mount point name xorriso : WARNING : -volid text is too long for Joliet (31 > 16) xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rul= es Added to ISO image: directory '/'=3D'/tmp/tmp.iIXC5zIfEd/master' xorriso : UPDATE : 227 files added in 1 seconds xorriso : UPDATE : 10 file filters processed in 1 seconds libisofs: WARNING : Cannot add /longsym to Joliet tree. Symlinks can only = be added to a Rock Ridge tree. libisofs: WARNING : Cannot add /psym to Joliet tree. Symlinks can only be = added to a Rock Ridge tree. libisofs: WARNING : Cannot add /sdir/ssym to Joliet tree. Symlinks can onl= y be added to a Rock Ridge tree. libisofs: WARNING : Cannot add /sdir/usym to Joliet tree. Symlinks can onl= y be added to a Rock Ridge tree. libisofs: WARNING : Cannot add /sym to Joliet tree. Symlinks can only be a= dded to a Rock Ridge tree. libisofs: WARNING : Filename not suitable for Joliet character set UCS-2 := "=C3=A9=C3=A0=C3=A8=C3=BC=C3=B6=C3=A4=C3=AB=C3=B1=D0=BA=D0=B8=D1=80=D0=B8= =D0=BB=D0=B8=D1=86=D0=B0=F0=AF=A6=9B=F0=AF=A6=9D=F0=AF=A6=99=CE=95=CE=BB= =CE=BB=CE=B7=CE=BD=CE=B9=CE=BA=CE=AC=F0=9F=98=81=F0=9F=98=9C=F0=9F=98=92" libisofs: WARNING : Filename not suitable for Joliet character set UCS-2 := "=CE=95=CE=BB=CE=BB=CE=B7=CE=BD=CE=B9=CE=BA=CE=AC=D0=BA=D0=B8=D1=80=D0=B8= =D0=BB=D0=B8=D1=86=D0=B0=F0=9F=98=81=F0=9F=98=9C=F0=9F=98=92=C3=A9=C3=A0= =C3=A8=C3=BC=C3=B6=C3=A4=C3=AB=C3=B1=F0=AF=A6=9B=F0=AF=A6=9D=F0=AF=A6=99" libisofs: WARNING : Cannot add /=CE=95=CE=BB=CE=BB=CE=B7=CE=BD=CE=B9=CE=BA= =CE=AC=D0=BA=D0=B8=D1=80=D0=B8=D0=BB=D0=B8=D1=86=D0=B0=F0=9F=98=81=F0=9F= =98=9C=F0=9F=98=92=C3=A9=C3=A0=C3=A8=C3=BC=C3=B6=C3=A4=C3=AB=C3=B1=F0=AF= =A6=9B=F0=AF=A6=9D=F0=AF=A6=99 to Joliet tree. Symlinks can only be added = to a Rock Ridge tree. xorriso : UPDATE : Writing: 1658s 32.2% fifo 0% buf 50% libisofs: WARNING : Sum of filenames not suitable for Joliet character set= UCS-2: 2 ISO image produced: 4978 sectors Written to medium : 5152 sectors at LBA 32 Writing to 'stdio:/tmp/tmp.iIXC5zIfEd/ziso9660_512_512_1_0.img' completed = successfully. Device proc: Filesystem type procfs - Sector size 512B - Total size 0KiB Device loop0: Filesystem type iso9660 - Label `gr_;/=C3=A9=F0=AF=A6=9B=F0= =AF=A6=9D=F0=9F=98=81=D0=BA=D0=B8=D1=80=D0=B8=D1=82 u' - Last modifition t= ime 2021-08-26 19:17:46 Thursday, UUID 2021-08-26-19-17-46-00 - Sector siz= e 512B - Total size 10368KiB Device host: Filesystem type hostfs - Sector size 512B - Total size 0KiB LIST FAIL DIR 20210826191746 ./ DIR 20210826191746 ../ DIR 20210826191745 0/ 1124311 20210826191746 1.img 257343 20210826191746 american-english 1124219 20210826191746 CaSe 1124683 20210826191746 cAsE 1124311 20210826191746 hard 1124653 20210826191746 longsym 1124353 20210826191746 psym 1124653 20210826191746 qwertzuiopasdfghjklyxcvbnm1234567890qwertzuiop= asdfghjklyxcvbnm1234567890oiewqfiewioqoiqoiurqruewqoiuwoieoiiuewqroreqiufi= eiuwrnureweriuvceoiroiewqoiricdsalkcndsakfirefoiwqeoircorejwoijfreoijojoie= wjfwnfcoirenfoirefnreoifenoiwfnoi DIR 20210826191746 sdir/ 1124311 20210826191746 sym 1124813 20210826191746 .?*\!"#%@$%&'()+ ,-.:;<=3D>^{_}[]`|~. 1124638 20210826191746 =C3=A9=C3=A0=C3=A8=C3=BC=C3=B6=C3=A4=C3=AB=C3= =B1=D0=BA=D0=B8=D1=80=D0=B8=D0=BB=D0=B8=D1=86=D0=B0=F0=AF=A6=9B=F0=AF=A6= =9D=F0=AF=A6=99=CE=95=CE=BB=CE=BB=CE=B7=CE=BD=CE=B9=CE=BA=CE=AC=F0=9F=98= =81=F0=9F=98=9C=F0=9F=98=92 1124638 20210826191746 =CE=95=CE=BB=CE=BB=CE=B7=CE=BD=CE=B9=CE=BA=CE= =AC=D0=BA=D0=B8=D1=80=D0=B8=D0=BB=D0=B8=D1=86=D0=B0=F0=9F=98=81=F0=9F=98= =9C=F0=9F=98=92=C3=A9=C3=A0=C3=A8=C3=BC=C3=B6=C3=A4=C3=AB=C3=B1=F0=AF=A6= =9B=F0=AF=A6=9D=F0=AF=A6=99 total 31692 drwxr-xr-x 3 thomas thomas 4096 Aug 26 19:17 0 -rw-r--r-- 2 thomas thomas 5242879 Aug 26 19:17 1.img -rw-r--r-- 1 thomas thomas 5242879 Aug 26 19:17 CaSe -rw-r--r-- 1 thomas thomas 972398 Aug 26 19:17 american-english -rw-r--r-- 1 thomas thomas 5242879 Aug 26 19:17 cAsE -rw-r--r-- 2 thomas thomas 5242879 Aug 26 19:17 hard lrwxrwxrwx 1 thomas thomas 227 Aug 26 19:17 longsym -> qwertzuiopasdfg= hjklyxcvbnm1234567890qwertzuiopasdfghjklyxcvbnm1234567890oiewqfiewioqoiqoi= urqruewqoiuwoieoiiuewqroreqiufieiuwrnureweriuvceoiroiewqoiricdsalkcndsakfi= refoiwqeoircorejwoijfreoijojoiewjfwnfcoirenfoirefnreoifenoiwfnoi lrwxrwxrwx 1 thomas thomas 806 Aug 26 19:17 psym -> /0//1/2/3//4/5/6//= 7/8/9//10/11/12//13/14/15//16/17/18//19/20/21//22/23/24//25/26/27//28/29/3= 0//31/32/33//34/35/36//37/38/39//40/41/42//43/44/45//46/47/48//49/50/51//5= 2/53/54//55/56/57//58/59/60//61/62/63//64/65/66//67/68/69//70/71/72//73/74= /75//76/77/78//79/80/81//82/83/84//85/86/87//88/89/90//91/92/93//94/95/96/= /97/98/99//100/101/102//103/104/105//106/107/108//109/110/111//112/113/114= //115/116/117//118/119/120//121/122/123//124/125/126//127/128/129//130/131= /132//133/134/135//136/137/138//139/140/141//142/143/144//145/146/147//148= /149/150//151/152/153//154/155/156//157/158/159//160/161/162//163/164/165/= /166/167/168//169/170/171//172/173/174//175/176/177//178/179/180//181/182/= 183//184/185/186//187/188/189//190/191/192//193/194/195//196/197/198//199/= 200/201//202/203/204//205/206/207//208/209/p.img -rw-r--r-- 1 thomas thomas 5242879 Aug 26 19:17 qwertzuiopasdfghjklyxcvbnm= 1234567890qwertzuiopasdfghjklyxcvbnm1234567890oiewqfiewioqoiqoiurqruewqoiu= woieoiiuewqroreqiufieiuwrnureweriuvceoiroiewqoiricdsalkcndsakfirefoiwqeoir= corejwoijfreoijojoiewjfwnfcoirenfoirefnreoifenoiwfnoi drwxr-xr-x 2 thomas thomas 4096 Aug 26 19:17 sdir lrwxrwxrwx 1 thomas thomas 5 Aug 26 19:17 sym -> 1.img -rw-r--r-- 1 thomas thomas 5242879 Aug 26 19:17 =C3=A9=C3=A0=C3=A8=C3=BC= =C3=B6=C3=A4=C3=AB=C3=B1=D0=BA=D0=B8=D1=80=D0=B8=D0=BB=D0=B8=D1=86=D0=B0= =F0=AF=A6=9B=F0=AF=A6=9D=F0=AF=A6=99=CE=95=CE=BB=CE=BB=CE=B7=CE=BD=CE=B9= =CE=BA=CE=AC=F0=9F=98=81=F0=9F=98=9C lrwxrwxrwx 1 thomas thomas 72 Aug 26 19:17 =CE=95=CE=BB=CE=BB=CE=B7= =CE=BD=CE=B9=CE=BA=CE=AC=D0=BA=D0=B8=D1=80=D0=B8=D0=BB=D0=B8=D1=86=D0=B0= =F0=9F=98=81=F0=9F=98=9C=F0=9F=98=92=C3=A9=C3=A0=C3=A8=C3=BC=C3=B6=C3=A4= =C3=AB=C3=B1=F0=AF=A6=9B=F0=AF=A6=9D=F0=AF=A6=99 -> =C3=A9=C3=A0=C3=A8=C3= =BC=C3=B6=C3=A4=C3=AB=C3=B1=D0=BA=D0=B8=D1=80=D0=B8=D0=BB=D0=B8=D1=86=D0= =B0=F0=AF=A6=9B=F0=AF=A6=9D=F0=AF=A6=99=CE=95=CE=BB=CE=BB=CE=B7=CE=BD=CE= =B9=CE=BA=CE=AC=F0=9F=98=81=F0=9F=98=9C=F0=9F=98=92 $ echo $? 1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D Have a nice day :) Thomas