All of lore.kernel.org
 help / color / mirror / Atom feed
From: "JiSheng Zhang" <jszhang3@mail.ustc.edu.cn>
To: stefanr@s5r6.in-berlin.de
Cc: linux-kernel@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, krh@redhat.com
Subject: PATCH] firewire: add padding to some struct
Date: Fri, 18 Jul 2008 16:58:53 +0800	[thread overview]
Message-ID: <416371533.19965@ustc.edu.cn> (raw)

>From JiSheng Zhang <jszhang3@mail.ustc.edu.cn>

struct fw_cdev_event_response and struct fw_cdev_event_iso_interrupt need padding.
Otherwise, offset of the zero length array is not equal to the struct size. It may
cause some strange problems under some platforms such as sparc32. This
patch(against 2.6.26) should fix it.


--- old/include/linux/firewire-cdev.h	2008-07-18 16:34:01.181794046 +0800
+++ new/include/linux/firewire-cdev.h	2008-07-18 16:35:46.649294275 +0800
@@ -92,6 +92,7 @@
 	__u32 type;
 	__u32 rcode;
 	__u32 length;
+	__u32 pad;
 	__u32 data[0];
 };
 
@@ -143,6 +144,7 @@
 	__u32 type;
 	__u32 cycle;
 	__u32 header_length;
+	__u32 pad;
 	__u32 header[0];
 };
 



             reply	other threads:[~2008-07-18  9:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18  8:58 JiSheng Zhang [this message]
2008-07-18 10:49 ` PATCH] firewire: add padding to some struct Stefan Richter
  -- strict thread matches above, loose matches on Subject: below --
2008-07-18 11:16 JiSheng Zhang
2008-07-18 11:38 ` Stefan Richter
2008-07-18 11:58   ` Stefan Richter
2008-07-18 12:07 JiSheng Zhang
2008-07-18 12:31 JiSheng Zhang
2008-07-18 15:27 ` Mikael Pettersson
     [not found] ` <416443505.10974@ustc.edu.cn>
2008-07-19  7:41   ` JiSheng Zhang
2008-07-19  7:41     ` JiSheng Zhang
2008-07-19 10:09       ` Mikael Pettersson
2008-07-19 10:32       ` Stefan Richter
     [not found]       ` <416463624.22263@ustc.edu.cn>
2008-07-20  6:20         ` JiSheng Zhang
2008-07-20  6:20           ` JiSheng Zhang
     [not found]     ` <416625421.30590@ustc.edu.cn>
2008-07-21  7:37       ` JiSheng Zhang
2008-07-21  7:37         ` JiSheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=416371533.19965@ustc.edu.cn \
    --to=jszhang3@mail.ustc.edu.cn \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.