All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Thomas Graf <tgraf@suug.ch>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb)
Date: Wed, 06 Oct 2004 16:06:54 -0300	[thread overview]
Message-ID: <4164424E.6000504@conectiva.com.br> (raw)
In-Reply-To: <20041006185835.GB19714@rei.reeler.org>



Thomas Graf wrote:
> * Arnaldo Carvalho de Melo <41643C40.8070605@conectiva.com.br> 2004-10-06 15:41
> 
>>-		trh = (struct trh_hdr *)skb_push(skb, sizeof(*trh));
>>+		skb->mac.raw = skb_push(skb, sizeof(*trh));
>>+		trh = tr_hdr(skb);
>> 		trh->ac = AC;
>> 		trh->fc = LLC_FRAME;
>> 		if (sa)
>>@@ -51,7 +52,6 @@
>> 			memcpy(trh->daddr, da, dev->addr_len);
>> 			tr_source_route(skb, trh, dev);
>> 		}
>>-		skb->mac.raw = skb->data;
> 
> 
> Are you sure the bevhaviour is the same? There is an skb_pull
> in tr_source_route so skb->data gets modified. 
> 
> 


Thanks for reviewing, checking...

  reply	other threads:[~2004-10-06 19:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-06 18:41 [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb) Arnaldo Carvalho de Melo
2004-10-06 18:58 ` Thomas Graf
2004-10-06 19:06   ` Arnaldo Carvalho de Melo [this message]
2004-10-06 19:18     ` Arnaldo Carvalho de Melo
2004-10-06 19:16       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4164424E.6000504@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.