From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Mowat Subject: blkif sort queue Date: Wed, 06 Oct 2004 23:02:06 -0700 Sender: xen-devel-admin@lists.sourceforge.net Message-ID: <4164DBDE.5060500@netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: xen-devel@lists.sourceforge.net List-Id: xen-devel@lists.xenproject.org Hi, I'm one of the engineers working on the FreeBSD port and while upgrading to TOT, I noticed that there appears to only be 1 sort queue for all guest domain devices (xlbd_blk_queue). All disks end up pointing at this request queue. The strategy call (do_blkif_request) uses this global queue and attempts to dequeue using elevator sort. Does any kind of sort make sense given that multiple devices feed this queue? I ask because some of the new recovery code attempts to call kick_pending_request_queues() in blkif_connect(). In my FreeBSD version prior to this I was using per disk sort queues, which was fine since I would only try to kick the i/o on interrupt completion. In this newer context it seems like having only 1 queue avoids the need to keep a table of per-disk sort queues. Thanks for any help. Eric ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl