From: "Chen, LingliX" <linglix.chen@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Guo, Jia" <jia.guo@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhou, JunX W" <junx.w.zhou@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask
Date: Tue, 9 Mar 2021 02:56:33 +0000 [thread overview]
Message-ID: <41677c8491704608ba25716b5ce21b0d@intel.com> (raw)
In-Reply-To: <20210301070607.24480-1-alvinx.zhang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alvin Zhang
> Sent: Monday, March 1, 2021 3:06 PM
> To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Zhou, JunX W <junx.w.zhou@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask
>
> The absolute field offsets of IPv4 or IPv6 header are related to hardware
> configuration. The X710 and X722 have different hardware configurations,
> and users can even modify the hardware configuration.
> Therefore, The default values cannot be used when calculating mask offset.
>
> The following flows can be created on X722 NIC, but the packet will not enter
> the queue 3:
> flow create 0 ingress pattern eth / ipv4 proto is 255 / end
> actions queue index 3 / end
> pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
> actions queue index 3 / end
> pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
> actions queue index 3 / end
> pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
> queue index 3 / end
> pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)
>
> This patch read the field offsets from the NIC and return the mask register
> value.
>
> Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow director")
> Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
all regression cases passed.
Tested-by: Chen Lingli <linglix.chen@intel.com>
next prev parent reply other threads:[~2021-03-09 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 2:09 [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR field mask Zhang,Alvin
2021-01-29 3:34 ` Xing, Beilei
2021-01-29 3:46 ` Zhang, AlvinX
2021-01-29 5:11 ` Zhang, AlvinX
2021-01-29 3:54 ` Zhou, JunX W
2021-02-01 2:40 ` [dpdk-dev] [PATCH v2] net/i40e: fix inputset " Zhang,Alvin
2021-02-01 3:26 ` Xing, Beilei
2021-03-01 7:06 ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2021-03-09 2:56 ` Chen, LingliX [this message]
2021-03-24 11:38 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2021-03-01 6:53 Alvin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41677c8491704608ba25716b5ce21b0d@intel.com \
--to=linglix.chen@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=junx.w.zhou@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.