All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Popov <ppopov@embeddedalley.com>
To: greg.nutt@cadenux.com
Cc: linux-mips@linux-mips.org
Subject: Re: Au1100 Serial Driver
Date: Sat, 09 Oct 2004 19:38:49 -0700	[thread overview]
Message-ID: <4168A0B9.7030801@embeddedalley.com> (raw)
In-Reply-To: <1097074752.9253.17.camel@spudrun>

Gregory Nutt wrote:

>I think I see an error in the serial driver for the Au1100.  In the
>function serial8250_isa_init_ports() there is the line:
>
>  up->port.uartclk  = get_au1x00_uart_baud_base();
>
>Shouldn't this be:
>
>  up->port.uartclk  = get_au1x00_uart_baud_base() * 16;
>
>Isn't the UART clock (normally) 16x the baud_base for this (and most)
>UARTs?
>
>Also... beware of:
>
>  baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); 
>  quot = serial8250_get_divisor(port, baud);
>  quot = 0x35; /* FIXME */
>
>For me, 0x35 is not correct.  For me, the above 16x fix eliminates
>the need for this kind of FIXME.
>  
>
Looks like an old hack that someone forgot to revisit :) Thanks for the 
patch.

Pete

      reply	other threads:[~2004-10-10  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-06 14:51 gcc 3.4 / bad_unaligned_access_length Gregory Nutt
2004-10-06 14:59 ` Au1100 Serial Driver Gregory Nutt
2004-10-10  2:38   ` Pete Popov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4168A0B9.7030801@embeddedalley.com \
    --to=ppopov@embeddedalley.com \
    --cc=greg.nutt@cadenux.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.