From: Ian Romanick <idr@us.ibm.com>
To: Dave Airlie <airlied@linux.ie>
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [RFC] [patch] drm core internal versioning..
Date: Mon, 11 Oct 2004 18:46:03 -0700 [thread overview]
Message-ID: <416B375B.2010508@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0410100050160.6083@skynet>
Dave Airlie wrote:
> An issue raised by DRM people with the new drm core is how to stop users
> shotting themselves in the foot when upgrading drm modules from CVS and
> mixing up cores and drivers...
>
> This patch (against DRM CVS) proposes a simple internal version that gets
> passed from the module to the core, when built in-kernel, it gets set to
> default DRM_INTERNAL_VERSION_KERNEL, when built in DRM CVS or snapshot, it
> gets DRM_INTERNAL_VERSION_EXTERNAL, a core built in one will refuse to
> load a module build in the other..
>
> This is quite a simple solution that should stop the most obvious issue,
> it doesn't stop people updating CVS drivers on top of themselves but my
> view is anyone doing this is either following our scripts or knows what
> they are doing...
I guess I don't get it. We want to prevent a DRM module that requires
core API N with a drm_core that exports M, M != N, right? So why not do
that? In that model don't you just need DRM_INTERNAL_VERSION? With the
setup you propose it seems like we could still have problems. If a user
installs a snapshot, then installs just a DRM from a later snapshot, etc.
prev parent reply other threads:[~2004-10-12 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-09 23:54 [RFC] [patch] drm core internal versioning Dave Airlie
2004-10-10 0:52 ` Jon Smirl
2004-10-10 2:31 ` Dave Airlie
2004-10-10 4:29 ` Greg KH
2004-10-10 5:30 ` Dave Airlie
2004-10-10 6:44 ` Arjan van de Ven
2004-10-10 7:00 ` Dave Airlie
2004-10-12 1:46 ` Ian Romanick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416B375B.2010508@us.ibm.com \
--to=idr@us.ibm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.