From: Jeff Garzik <jgarzik@pobox.com>
To: Jesse Barnes <jbarnes@sgi.com>
Cc: netdev@oss.sgi.com, "David S. Miller" <davem@redhat.com>
Subject: Re: [PATCH] work around 5701 misalignment
Date: Wed, 13 Oct 2004 16:57:28 -0400 [thread overview]
Message-ID: <416D96B8.5090204@pobox.com> (raw)
In-Reply-To: <200410131554.19845.jbarnes@sgi.com>
Jesse Barnes wrote:
> --- a/linux/drivers/net/tg3.c 2004-10-13 15:25:03.000000000 -0500
> +++ b/linux/drivers/net/tg3.c 2004-10-13 15:14:45.000000000 -0500
> @@ -2352,7 +2352,12 @@
>
> len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4; /* omit crc */
>
> - if (len > RX_COPY_THRESHOLD) {
> + if (len > RX_COPY_THRESHOLD
> +#if defined(CONFIG_UNALIGNED_EXPENSIVE)
> + && tp->rx_offset == 2
> +#endif
hmmm, the normal solution is to give RX_COPY_THRESHOLD a per-arch value.
Grep for 'rx_copybreak' in bunches of net drivers.
DaveM might squirm a bit but IMHO RX_COPY_THRESHOLD really is
platform-dependent.
Jeff
next prev parent reply other threads:[~2004-10-13 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-13 20:54 [PATCH] work around 5701 misalignment Jesse Barnes
2004-10-13 20:57 ` Jeff Garzik [this message]
2004-10-20 6:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416D96B8.5090204@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=jbarnes@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.