From: Jeff Garzik <jgarzik@pobox.com>
To: ravinandan.arakali@s2io.com
Cc: "'Francois Romieu'" <romieu@fr.zoreil.com>,
netdev@oss.sgi.com, leonid.grossman@s2io.com,
raghavendra.koushik@s2io.com, rapuru.sriram@s2io.com
Subject: Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode
Date: Thu, 14 Oct 2004 11:03:44 -0400 [thread overview]
Message-ID: <416E9550.4060001@pobox.com> (raw)
In-Reply-To: <005a01c4b18b$c1fd7400$6c10100a@S2IOtech.com>
no objections but two comments:
1) can this not be done with SKB fragments?
2) the following code needlessly uses GFP_ATOMIC:
> + ba = &nic->ba[i][j][k];
> +
> + ba->ba_0_org = (void *) kmalloc
> + (BUF0_LEN + ALIGN_SIZE, GFP_ATOMIC);
and there is another example just a bit down from that one.
next prev parent reply other threads:[~2004-10-14 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 1:18 [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode Ravinandan Arakali
2004-10-14 15:03 ` Jeff Garzik [this message]
2004-10-14 18:33 ` Raghavendra Koushik
2004-10-14 20:49 ` Chris Leech
2004-10-15 0:02 ` Raghavendra Koushik
2004-10-15 0:21 ` Leonid Grossman
2004-10-15 18:47 ` Jeff Garzik
2004-10-15 19:48 ` Leonid Grossman
2004-10-15 19:57 ` Andi Kleen
2004-10-15 23:14 ` Raghavendra Koushik
2004-10-15 23:15 ` Jeff Garzik
2004-10-14 15:05 ` s2io: patch disposition Jeff Garzik
2004-10-18 22:06 ` Ravinandan Arakali
2004-10-18 22:04 ` Jeff Garzik
2004-10-18 22:21 ` Francois Romieu
2004-10-18 22:38 ` Ravinandan Arakali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416E9550.4060001@pobox.com \
--to=jgarzik@pobox.com \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=rapuru.sriram@s2io.com \
--cc=ravinandan.arakali@s2io.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.