From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.9-rc4 2/3] ns83820: move eeprom.h and clean up
Date: Fri, 15 Oct 2004 19:44:22 -0400 [thread overview]
Message-ID: <417060D6.3080100@pobox.com> (raw)
In-Reply-To: <20041015154400.11611d9b@zqx3.pdx.osdl.net>
Stephen Hemminger wrote:
> The file linux/eeprom.h was only being used by the ns83820 driver,
> and it contained non-inline functions in a .h file. This patch
> fixes that and:
> * Only two functions are actually used (and only used once)
> so ditch the rest and make those inline.
> * EEprom is in iomemory space so get rid of the warnings.
>
> Compiles but I don't have this hardware, so it has not been tested.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
actually, Ben's idea with linux/eeprom.h was to stop duplicating the
same eeprom logic in each driver, and centralize it instead.
Did you look at trying to do that?
Jeff
prev parent reply other threads:[~2004-10-15 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 22:44 [PATCH 2.6.9-rc4 2/3] ns83820: move eeprom.h and clean up Stephen Hemminger
2004-10-15 23:44 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417060D6.3080100@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.