From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@redhat.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6]: Fix policy update bug when increasing priority of last policy
Date: Tue, 19 Oct 2004 16:24:12 +0200 [thread overview]
Message-ID: <4175238C.7010907@trash.net> (raw)
In-Reply-To: <E1CJhER-0001vk-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
>Patrick McHardy <kaber@trash.net> wrote:
>
>>This patch checks for *p != NULL before continuing the loop.
>>
>>
>
>Unfortunately that doesn't fix it completely. The real bug is
>the fact that we continue with a bogus p pointing to the deleted
>element. So what we should do is continue without updating p
>at all.
>
>
You're right, your patch is better. I've tested
it and it works fine.
Regards
Patrick
next prev parent reply other threads:[~2004-10-19 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-18 20:48 [PATCH 2.6]: Fix policy update bug when increasing priority of last policy Patrick McHardy
2004-10-18 23:48 ` Herbert Xu
2004-10-19 14:24 ` Patrick McHardy [this message]
2004-10-21 5:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4175238C.7010907@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.